From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: mvebu: don't hardcode a physical address in headsmp.S
Date: Thu, 6 Jun 2013 13:45:02 +0100 [thread overview]
Message-ID: <20130606124502.GE16794@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1370514268-9159-1-git-send-email-thomas.petazzoni@free-electrons.com>
On Thu, Jun 06, 2013 at 11:24:28AM +0100, Thomas Petazzoni wrote:
> Now that the coherency_init() function is called a bit earlier, we can
> actually read the physical address of the coherency unit registers
> from the Device Tree, and communicate that to the headsmp.S code,
> which avoids hardcoding a physical address.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Changes from v1 to v2:
>
> * Simplified the code in headsmp.S to compute the physical address of
> the coherency unit base address. Suggested by Nicolas Pitre.
>
> * Added a sync_cache_w() call to ensure the physical address of the
> coherency unit stored in the coherency_phys_base is visible by the
> other CPUs. The other CPUs are reading this before they join the
> coherency fabric, so we need to make some manual cache coherency
> here. Noticed by Will Deacon.
>
> arch/arm/mach-mvebu/coherency.c | 12 ++++++++++++
> arch/arm/mach-mvebu/headsmp.S | 16 ++++++++--------
> 2 files changed, 20 insertions(+), 8 deletions(-)
This looks better to me, cheers.
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2013-06-06 12:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 7:04 [PATCH 0/8] Support Marvell bootloaders remapping registers at different locations Thomas Petazzoni
2013-06-05 7:04 ` [PATCH 1/8] arm: mvebu: remove dependency of SMP init on static I/O mapping Thomas Petazzoni
2013-06-05 7:04 ` [PATCH 2/8] arm: mvebu: avoid hardcoded virtual address in coherency code Thomas Petazzoni
2013-06-05 7:04 ` [PATCH 3/8] arm: mvebu: move cache and mvebu-mbus initialization later Thomas Petazzoni
2013-06-05 7:04 ` [PATCH 4/8] arm: mvebu: remove hardcoded static I/O mapping Thomas Petazzoni
2013-06-05 7:04 ` [PATCH 5/8] arm: mvebu: don't hardcode a physical address in headsmp.S Thomas Petazzoni
2013-06-05 20:42 ` Nicolas Pitre
2013-06-05 21:33 ` Thomas Petazzoni
2013-06-06 9:13 ` Will Deacon
2013-06-06 10:27 ` Thomas Petazzoni
2013-06-06 10:24 ` [PATCH v2] " Thomas Petazzoni
2013-06-06 12:45 ` Will Deacon [this message]
2013-06-06 16:49 ` Nicolas Pitre
2013-06-06 17:59 ` Jason Cooper
2013-06-05 7:04 ` [PATCH 6/8] arm: mvebu: don't hardcode the physical address for mvebu-mbus Thomas Petazzoni
2013-06-05 7:05 ` [PATCH 7/8] arm: mvebu: add another earlyprintk Kconfig option Thomas Petazzoni
2013-06-05 13:45 ` Jason Cooper
2013-06-05 13:47 ` Thomas Petazzoni
2013-06-05 14:07 ` Jason Cooper
2013-06-05 7:05 ` [PATCH 8/8] arm: mvebu: disable DEBUG_LL/EARLY_PRINTK in defconfig Thomas Petazzoni
2013-06-05 8:34 ` [PATCH 0/8] Support Marvell bootloaders remapping registers at different locations Arnd Bergmann
2013-06-05 21:01 ` Jason Cooper
2013-06-06 18:02 ` Jason Cooper
2013-06-07 7:45 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606124502.GE16794@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).