From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] ARM: imx: clk-pllv3: change wait method for PLL lock
Date: Fri, 7 Jun 2013 10:35:28 +0200 [thread overview]
Message-ID: <20130607083528.GG12361@pengutronix.de> (raw)
In-Reply-To: <20130607083134.GE21641@nchen-desktop>
On Fri, Jun 07, 2013 at 04:31:35PM +0800, Peter Chen wrote:
> On Fri, Jun 07, 2013 at 10:24:57AM +0200, Uwe Kleine-K?nig wrote:
> > On Fri, Jun 07, 2013 at 04:19:06PM +0800, Peter Chen wrote:
> > > For some unknown reasons, the jiffies will be updated more
> > > than one tick at every short time. Eg, at this code:
> > > After timeout = jiffies + msecs_to_jiffies(10),
> > > the interrupt occurs, and the softirq updates jiffies (eg, + 2 jiffies),
> > > then return back from interrupt, the time between above operations
> > > are tiny, the PLL is still not locked, but the timeout condition is satisfied.
> > >
> > > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > Does this mean my patch doesn't solve the issue for you?
>
> Not try, but your patch just delay timeout assignment, if there
> is jiffies update after that but before timeout check, it still
> has problem.
But if that large update happens because there was a long preemption the
pll should be locked because I only start counting when the pll is
programmed.
IMHO you should try my patch as it is the better fix (assuming it fixes
it for you).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2013-06-07 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 8:19 [PATCH v2 1/1] ARM: imx: clk-pllv3: change wait method for PLL lock Peter Chen
2013-06-07 8:24 ` Uwe Kleine-König
2013-06-07 8:31 ` Peter Chen
2013-06-07 8:35 ` Uwe Kleine-König [this message]
2013-06-07 8:43 ` Peter Chen
2013-06-07 8:49 ` Uwe Kleine-König
2013-06-07 11:07 ` Shawn Guo
2013-06-08 1:09 ` Peter Chen
2013-07-14 0:43 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607083528.GG12361@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).