public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (maxime.ripard at free-electrons.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp
Date: Fri, 7 Jun 2013 11:02:28 +0200	[thread overview]
Message-ID: <20130607090228.GI14209@lukather> (raw)
In-Reply-To: <51B1957F.40104@digi.com>

Hi Hector,

On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote:
> For a combination of 18bit LCD data bus width and a color
> mode of 32bpp, the driver was setting the color mapping to
> rgb666, which is wrong, as the color in memory realy has an
> rgb888 layout.
> 
> This patch also removes the setting of flag CTRL_DF24 that
> makes the driver dimiss the upper 2 bits when handling 32/24bpp
> colors in a diplay with 18bit data bus width. This flag made
> true color images display wrong in such configurations.
> 
> Finally, the color mapping rgb666 has also been removed as nobody
> is using it and high level applications like Qt5 cannot work
> with it either.
> 
> Reference: https://lkml.org/lkml/2013/5/23/220
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> Acked-by: Juergen Beisert <jbe@pengutronix.de>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Please also note that fbdev is now maintained by Jean Christophe
Plagniol-Villard (plagnioj at jcrosoft.com, in CC), and that he is away
until the 10th of June, so maybe it should be safe to resend it to him
after this date.

Thanks!
Maxime

  reply	other threads:[~2013-06-07  9:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <519E03B0.1080006@digi.com>
2013-05-23 13:00 ` mxsfb: DATA_FORMAT_24_BIT flag outputs invalid colours maxime.ripard at free-electrons.com
2013-05-23 13:31   ` Juergen Beisert
2013-05-23 15:56     ` Hector Palacios
2013-05-24 10:28       ` Juergen Beisert
2013-05-24 10:43         ` Hector Palacios
2013-05-24 11:00           ` Juergen Beisert
2013-05-24 13:33             ` Juergen Beisert
2013-06-07  7:21               ` maxime.ripard at free-electrons.com
2013-06-07  7:28                 ` Hector Palacios
2013-06-07  7:34                   ` Juergen Beisert
2013-06-07  7:42                   ` maxime.ripard at free-electrons.com
2013-06-07  8:10                     ` [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp Hector Palacios
2013-06-07  9:02                       ` maxime.ripard at free-electrons.com [this message]
2013-06-18  8:32                         ` maxime.ripard at free-electrons.com
2013-06-18  8:45                           ` Hector Palacios
2013-05-24  8:11     ` mxsfb: DATA_FORMAT_24_BIT flag outputs invalid colours maxime.ripard at free-electrons.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130607090228.GI14209@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox