From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line
Date: Fri, 7 Jun 2013 14:31:30 -0500 [thread overview]
Message-ID: <20130607193130.GA13205@kahuna> (raw)
In-Reply-To: <1370629886-14170-1-git-send-email-khilman@linaro.org>
On 11:31-20130607, Kevin Hilman wrote:
> On most OMAP3 platforms, the twl4030 IRQ line is connected to the
> SYS_NIRQ line on OMAP. Add another DTS include file
> (twl4030_omap3.dtsi) for boards that hook up the twl4030 this way
> to include.
>
> This allows RTC wake from off-mode to work again on OMAP3-based
> platforms with twl4030. Tested on 3530/Beagle, 3730/Beagle-xM,
> 3530/Overo, 3730/Overo-STORM.
>
> Special thanks to Florian Vaussard for suggesting use of preprocessor
> feature.
>
> Cc: Florian Vaussard <florian.vaussard@epfl.ch>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
Thanks,
Reviewed-by: Nishanth Menon <nm@ti.com>
> ---
> v3: renamed to twl4030_omap3 (suggested by Nishanth), add GPL, fix whitespace
> v2: Updated to change board files instead of twl4030 file.
>
> arch/arm/boot/dts/omap3-beagle-xm.dts | 1 +
> arch/arm/boot/dts/omap3-beagle.dts | 1 +
> arch/arm/boot/dts/omap3-devkit8000.dts | 1 +
> arch/arm/boot/dts/omap3-evm.dts | 1 +
> arch/arm/boot/dts/omap3-igep.dtsi | 1 +
> arch/arm/boot/dts/omap3-overo.dtsi | 1 +
> arch/arm/boot/dts/omap3430-sdp.dts | 1 +
> arch/arm/boot/dts/twl4030_omap3.dtsi | 25 +++++++++++++++++++++++++
> 8 files changed, 32 insertions(+)
> create mode 100644 arch/arm/boot/dts/twl4030_omap3.dtsi
>
> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
> index ad17b6b..afdb164 100644
> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> @@ -96,6 +96,7 @@
> };
>
> #include "twl4030.dtsi"
> +#include "twl4030_omap3.dtsi"
>
> &i2c2 {
> clock-frequency = <400000>;
> diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
> index eb7e02a..dfd8310 100644
> --- a/arch/arm/boot/dts/omap3-beagle.dts
> +++ b/arch/arm/boot/dts/omap3-beagle.dts
> @@ -135,6 +135,7 @@
> };
>
> #include "twl4030.dtsi"
> +#include "twl4030_omap3.dtsi"
>
> &mmc1 {
> vmmc-supply = <&vmmc1>;
> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
> index 5be71b1..af32eff 100644
> --- a/arch/arm/boot/dts/omap3-devkit8000.dts
> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> @@ -81,6 +81,7 @@
> };
>
> #include "twl4030.dtsi"
> +#include "twl4030_omap3.dtsi"
>
> &mmc1 {
> vmmc-supply = <&vmmc1>;
> diff --git a/arch/arm/boot/dts/omap3-evm.dts b/arch/arm/boot/dts/omap3-evm.dts
> index baa24bb..7d4329d 100644
> --- a/arch/arm/boot/dts/omap3-evm.dts
> +++ b/arch/arm/boot/dts/omap3-evm.dts
> @@ -45,6 +45,7 @@
> };
>
> #include "twl4030.dtsi"
> +#include "twl4030_omap3.dtsi"
>
> &i2c2 {
> clock-frequency = <400000>;
> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
> index 5224c29..bc48b11 100644
> --- a/arch/arm/boot/dts/omap3-igep.dtsi
> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
> @@ -87,6 +87,7 @@
> };
>
> #include "twl4030.dtsi"
> +#include "twl4030_omap3.dtsi"
>
> &i2c2 {
> clock-frequency = <400000>;
> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi
> index 144a5a2..4bc78896 100644
> --- a/arch/arm/boot/dts/omap3-overo.dtsi
> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
> @@ -50,6 +50,7 @@
> };
>
> #include "twl4030.dtsi"
> +#include "twl4030_omap3.dtsi"
>
> /* i2c2 pins are used for gpio */
> &i2c2 {
> diff --git a/arch/arm/boot/dts/omap3430-sdp.dts b/arch/arm/boot/dts/omap3430-sdp.dts
> index 2a725a0..c4a1c0a 100644
> --- a/arch/arm/boot/dts/omap3430-sdp.dts
> +++ b/arch/arm/boot/dts/omap3430-sdp.dts
> @@ -29,6 +29,7 @@
> };
>
> #include "twl4030.dtsi"
> +#include "twl4030_omap3.dtsi"
>
> &mmc1 {
> vmmc-supply = <&vmmc1>;
> diff --git a/arch/arm/boot/dts/twl4030_omap3.dtsi b/arch/arm/boot/dts/twl4030_omap3.dtsi
> new file mode 100644
> index 0000000..c353ef0
> --- /dev/null
> +++ b/arch/arm/boot/dts/twl4030_omap3.dtsi
> @@ -0,0 +1,25 @@
> +/*
> + * Copyright (C) 2013 Linaro, Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +&twl {
> + pinctrl-names = "default";
> + pinctrl-0 = <&twl4030_pins>;
> +};
> +
> +&omap3_pmx_core {
> + /*
> + * On most OMAP3 platforms, the twl4030 IRQ line is connected
> + * to the SYS_NIRQ line on OMAP. Therefore, configure the
> + * defaults for the SYS_NIRQ pin here.
> + */
> + twl4030_pins: pinmux_twl4030_pins {
> + pinctrl-single,pins = <
> + 0x1b0 (PIN_INPUT_PULLUP | PIN_OFF_WAKEUPENABLE | MUX_MODE0) /* sys_nirq.sys_nirq */
> + >;
> + };
> +};
> --
> 1.8.3
>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-06-07 19:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:45 [PATCH 0/3] ARM: DTS: misc. OMAP3 fixes for proper wakeup Kevin Hilman
2013-05-31 22:45 ` [PATCH 1/3] ARM: DTS: OMAP3: beagle/overo: mux console UART, enable wakeup Kevin Hilman
2013-06-03 9:36 ` Florian Vaussard
2013-06-03 21:26 ` Kevin Hilman
2013-05-31 22:45 ` [PATCH 2/3] ARM: DTS: OMAP3: beagle: enable user button via gpio_keys, " Kevin Hilman
2013-06-03 9:40 ` Florian Vaussard
2013-05-31 22:45 ` [PATCH 3/3] ARM: DTS: TWL4030: fix mux and wakeup for SYS_NIRQ line Kevin Hilman
2013-06-03 9:48 ` Florian Vaussard
2013-06-03 22:19 ` Kevin Hilman
2013-06-03 22:39 ` Jason Cooper
2013-06-04 17:58 ` Kevin Hilman
2013-06-04 18:05 ` Jason Cooper
2013-06-05 7:41 ` Florian Vaussard
2013-06-05 13:52 ` Benoit Cousson
2013-06-05 14:26 ` Kevin Hilman
2013-06-06 23:27 ` [PATCH v2 " Kevin Hilman
2013-06-06 23:42 ` Nishanth Menon
2013-06-07 16:59 ` Kevin Hilman
2013-06-07 18:31 ` [PATCH v3] " Kevin Hilman
2013-06-07 19:31 ` Nishanth Menon [this message]
2013-06-10 9:22 ` Benoit Cousson
2013-06-10 16:40 ` Kevin Hilman
2013-06-11 11:33 ` Cousson, Benoit
2013-06-11 11:43 ` Benoit Cousson
2013-06-11 14:30 ` Kevin Hilman
2013-06-19 1:25 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607193130.GA13205@kahuna \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).