From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: mvebu: Add the i2c-bridge capability to the mv64xxx-i2c
Date: Fri, 7 Jun 2013 20:52:34 +0100 [thread overview]
Message-ID: <20130607195234.GZ18614@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1370619743-15245-3-git-send-email-gregory.clement@free-electrons.com>
On Fri, Jun 07, 2013 at 05:42:23PM +0200, Gregory CLEMENT wrote:
> The mv64xxx-i2c embedded in the Armada XP have a new feature called
> i2c-bridge. This commit split the i2c information into armada-370.dtsi
> and armada-xp.dtsi. Most of the data remains the same and stay in the
> common file Armada-370-xp.dtsi. With this new feature the size of the
> registers are bigger for Armada XP and for this SoCs we add a new flag
> for the i2c-bridge capability.
Personally, I don't like this "i2c-bridge" flag either, but for a different
reason - i2c-bridge makes it sound like it's doing something it's not.
What it is doing is as you stated in the cover - it's an offload mechanism,
just like if it were possible to use DMA to supply the data to the I2C
interface.
I think Maxime is correct - this should be identified by a variation in
the compatible string, not by a flag in DT.
prev parent reply other threads:[~2013-06-07 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 15:42 [PATCH 0/2] i2c-mv64xxx: Add I2C Transaction Generator support Gregory CLEMENT
2013-06-07 15:42 ` [PATCH 1/2] " Gregory CLEMENT
2013-06-07 16:21 ` Thomas Petazzoni
2013-06-07 19:57 ` Russell King - ARM Linux
2013-06-07 15:42 ` [PATCH 2/2] ARM: dts: mvebu: Add the i2c-bridge capability to the mv64xxx-i2c Gregory CLEMENT
2013-06-07 17:03 ` Maxime Ripard
2013-06-07 18:09 ` Jason Cooper
2013-06-07 18:50 ` Thomas Petazzoni
2013-06-07 19:52 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130607195234.GZ18614@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).