From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs
Date: Mon, 10 Jun 2013 15:10:51 +0200 [thread overview]
Message-ID: <201306101510.51961.heiko@sntech.de> (raw)
In-Reply-To: <CACRpkdaEcZZ3NZzwKOhUPjvFg+bSZ=UbpyPT2EBcAfVv1-EsKA@mail.gmail.com>
Am Montag, 10. Juni 2013, 15:00:41 schrieb Linus Walleij:
> On Sun, Jun 9, 2013 at 2:01 AM, Heiko St?bner <heiko@sntech.de> wrote:
>
> (...)
>
> > +#include <linux/irqchip/chained_irq.h>
> > +#include <linux/clk-provider.h>
> > +#include <dt-bindings/pinctrl/rockchip.h>
>
> Hm I don't know if we're supposed to do things like this actually.
>
> It depends on whether the <dt-bindings/*> hierarchy is supposed
> to stay in the kernel after the device trees are moved out to a
> separate repo.
>
> Grant/Rob, shall we do this in drivers?
we can get rid of it, if it's controversial.
The only constant that gets used is RK_FUNC_GPIO in
rockchip_pmx_gpio_set_direction and rockchip_irq_set_type to not have arbitary
"0"-values when switching to the gpio function.
So it wouldn't be problem to simply keep this constant in the driver itself
instead of including the dt-binding constants.
next prev parent reply other threads:[~2013-06-10 13:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 23:59 [PATCH 0/2] pinctrl: common handling of generic pinconfig props in dt Heiko Stübner
2013-06-08 23:59 ` [PATCH 1/2] pinctrl: add devicetree constants for simple generic pnconfig options Heiko Stübner
2013-06-09 0:00 ` [PATCH 2/2] pinctrl: add function to separate combined pinconfig values Heiko Stübner
2013-06-09 0:01 ` [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs Heiko Stübner
2013-06-10 12:55 ` Linus Walleij
2013-06-10 13:00 ` Linus Walleij
2013-06-10 13:10 ` Heiko Stübner [this message]
2013-06-10 13:35 ` [PATCH v2] " Heiko Stübner
2013-06-10 13:40 ` [EXAMPLE PATCH] " Linus Walleij
2013-06-10 18:23 ` Stephen Warren
2013-06-10 19:53 ` Rob Herring
2013-06-11 8:50 ` Linus Walleij
2013-06-10 12:52 ` [PATCH 0/2] pinctrl: common handling of generic pinconfig props in dt Linus Walleij
2013-06-10 13:06 ` Heiko Stübner
2013-06-10 13:39 ` Linus Walleij
2013-06-10 13:54 ` Heiko Stübner
2013-06-10 14:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306101510.51961.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).