From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Mon, 10 Jun 2013 22:09:07 +0200 Subject: [PATCH V4 2/4] ARM: tegra: pcie: Add tegra3 support In-Reply-To: <51AF68F1.8080307@wwwdotorg.org> References: <1370445221-17696-1-git-send-email-jagarwal@nvidia.com> <51AF68F1.8080307@wwwdotorg.org> Message-ID: <20130610200906.GD25859@mithrandir> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 05, 2013 at 10:36:01AM -0600, Stephen Warren wrote: > On 06/05/2013 09:13 AM, Jay Agarwal wrote: > > - Make private data structure for each SoC > > - Add required Tegra30 clocks and regulators > > - Add Tegra30 specific code in enable controller > > - Added Tegra30 specific properties in pci binding document > > It's a bit odd to send an updated version of just some of the patches; > reposting a whole series is much easier for the person applying the > patches. However, hopefully Thierry can handle it in this case. Yes, I think I can handle it. It might be good to have Jay look at the final patches when I'm done, though, to make sure I haven't forgotten anything. > > diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt > > > Required properties: > > -- compatible: "nvidia,tegra20-pcie" > > +- compatible: "nvidia,tegra20-pcie" "nvidia,tegra30-pcie" > > perhaps add "or" between those two entries? > > > +- avdd-supply: Power supply for controller (1.05V) (not required for tegra20) > ... > > + "cml": The Tegra clock of that name (not required for tegra20) > > Tegra20 should be capitalized in both those two lines. > > I assume that Thierry can fix up these nits when he applies the patches, > so you don't need to repost. Thierry can correct me if I'm wrong. I've found a few other nits that I can take care of myself when applying. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: