From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 11 Jun 2013 12:12:54 +0100 Subject: [PATCH 19/33] clk: ux500: Add Device Tree support for the PRCMU clock In-Reply-To: <20130611111050.GC3330@laptop> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-20-git-send-email-lee.jones@linaro.org> <20130611111050.GC3330@laptop> Message-ID: <20130611111254.GD3330@laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 11 Jun 2013, Lee Jones wrote: > On Mon, 10 Jun 2013, Ulf Hansson wrote: > > > On 6 June 2013 14:17, Lee Jones wrote: > > > This patch enables clocks to be specified from Device Tree via phandles > > > to the "prcmu-clock" node. > > > > > > Cc: Mike Turquette > > > Cc: Ulf Hansson > > > Signed-off-by: Lee Jones > > > --- > > > drivers/clk/ux500/u8500_clk.c | 50 +++++++++++++++++++++++++++++++++++++++-- > > > 1 file changed, 48 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/clk/ux500/u8500_clk.c b/drivers/clk/ux500/u8500_clk.c > > > index 3a7040b..4f5ad4c 100644 > > > --- a/drivers/clk/ux500/u8500_clk.c > > > +++ b/drivers/clk/ux500/u8500_clk.c > > > @@ -15,6 +15,8 @@ > > > #include > > > #include "clk.h" > > > > > > +static struct clk *prcmu_clk[PRCMU_NUM_CLKS]; > > > + > > > struct clk *ux500_twocell_get(struct of_phandle_args *clkspec, void *data) > > > > Actually I thought ux500_twocell_get was going to be used in this > > patch, since the previous one was adding this helper function, but it > > isn't? > > Yes it is: Whoops! No, it's using it in the next patch. There's no requirement for these things to be sequential. I thought it was better to put adding the clocks sequential, rather than have a random addition of a call-back function in the middle of them. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog