From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@linaro.org (Shawn Guo) Date: Thu, 13 Jun 2013 12:12:09 +0800 Subject: [PATCH] thermal: add imx thermal driver support In-Reply-To: <1371093177.2135.24.camel@rzhang1-mobl4> References: <1370330008-5982-1-git-send-email-shawn.guo@linaro.org> <1371093177.2135.24.camel@rzhang1-mobl4> Message-ID: <20130613041207.GA14259@S2101-09.ap.freescale.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 13, 2013 at 11:12:57AM +0800, Zhang Rui wrote: > On Tue, 2013-06-04 at 15:13 +0800, Shawn Guo wrote: > > This is based on the initial imx thermal work done by > > Rob Lee (Not sure if the email address is still > > valid). Since he is no longer interested in the work and I have > > rewritten a significant amount of the code, I just took the authorship > > over from him. > > > > It adds the imx thermal support using Temperature Monitor (TEMPMON) > > block found on some Freescale i.MX SoCs. The driver uses syscon regmap > > interface to access TEMPMON control registers and calibration data, and > > supports cpufreq as the cooling device. > > > you're using the cpufrq_cooling to throttle cpus at 85C, right? Yes. > then you should register it as THERMAL_TRIP_PASSIVE instead of > THERMAL_TRIP_ACTIVE. Yes, literally it should be a passive trip point rather than active one. But I'm not sure if there is any real functional differences between them in my thermal case, except I have to give both passive_delay and polling_delay in thermal_zone_device_register() call for passive type while it only needs polling_delay for active type to work properly. Besides, both exynos and db8500 thermal drivers register active trip point while they are using cpufreq as the cooling device. So I thought it's fine to not have the trip type literally correct. Shawn