From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889)
Date: Fri, 14 Jun 2013 17:24:30 +0200 [thread overview]
Message-ID: <20130614152430.GF2929@katana> (raw)
In-Reply-To: <20130607182500.10593e73@skate>
On Fri, Jun 07, 2013 at 06:25:00PM +0200, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> On Fri, 7 Jun 2013 17:48:59 +0200, Gregory CLEMENT wrote:
>
> > +/*
> > + * 5us delay in order to avoid repeated start
> > + * timing violation on Armada XP SoC.
> > + */
> > +static int mv64xxx_i2c_errata_delay;
>
> This should probably be a per-I2C controller variable, i.e in
> mv64xxx_i2c_data.
Yes.
>
>
> > + if (!mv64xxx_i2c_errata_delay &&
> > + of_machine_is_compatible("marvell,armadaxp"))
> > + mv64xxx_i2c_errata_delay = 1;
>
> I am wondering whether it should be done this way, or using a separate
> DT property.
Need to think about it. It is similar to the sda-hold-time issue, I
guess.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130614/e78ff3be/attachment.sig>
next prev parent reply other threads:[~2013-06-14 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 15:48 [PATCH 0/2] i2c-mv64xxx: Various fixes Gregory CLEMENT
2013-06-07 15:48 ` [PATCH 1/2] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889) Gregory CLEMENT
2013-06-07 16:25 ` Thomas Petazzoni
2013-06-14 15:24 ` Wolfram Sang [this message]
2013-06-07 15:49 ` [PATCH 2/2] i2c-mv64xxx: Abort the mv64xxx_of_config if clock-frequency is not provided Gregory CLEMENT
2013-06-14 15:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614152430.GF2929@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).