From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] serial: sh-sci: HSCIF support
Date: Mon, 17 Jun 2013 14:54:48 +0200 [thread overview]
Message-ID: <201306171454.48936.arnd@arndb.de> (raw)
In-Reply-To: <1371440327-30512-2-git-send-email-horms+renesas@verge.net.au>
On Monday 17 June 2013, Simon Horman wrote:
> - if (likely(baud && port->uartclk))
> - t = sci_scbrr_calc(s->cfg->scbrr_algo_id, baud, port->uartclk);
> + if (likely(baud && port->uartclk)) {
> + if (s->cfg->scbrr_algo_id == SCBRR_ALGO_6) {
> + sci_baud_calc_hscif(baud, port->uartclk, &t, &srr,
> + &cks);
> + } else {
> + t = sci_scbrr_calc(s->cfg->scbrr_algo_id, baud,
> + port->uartclk);
> + for (cks = 0; t >= 256 && cks <= 3; cks++)
> + t >>= 2;
> + }
> + }
This hunk causes build warnings in linux-next now:
/git/arm-soc/drivers/tty/serial/sh-sci.c: In function 'sci_set_termios':
/git/arm-soc/drivers/tty/serial/sh-sci.c:1942:37: warning: 'srr' may be used uninitialized in this function [-Wmaybe-uninitialized]
serial_port_out(port, HSSRR, srr | HSCIF_SRE);
^
/git/arm-soc/drivers/tty/serial/sh-sci.c:1892:15: note: 'srr' was declared here
unsigned int srr;
^
/git/arm-soc/drivers/tty/serial/sh-sci.c:1938:47: warning: 'cks' may be used uninitialized in this function [-Wmaybe-uninitialized]
serial_port_out(port, SCSMR, (smr_val & ~3) | cks);
^
/git/arm-soc/drivers/tty/serial/sh-sci.c:1890:40: note: 'cks' was declared here
unsigned int baud, smr_val, max_baud, cks;
^
Arnd
next prev parent reply other threads:[~2013-06-17 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 3:38 [GIT PULL 0/2 v2] Renesas sh-sci updates for v3.11 Simon Horman
2013-06-17 3:38 ` [PATCH 1/2] serial: sh-sci: HSCIF support Simon Horman
2013-06-17 12:54 ` Arnd Bergmann [this message]
2013-06-18 1:19 ` Simon Horman
2013-06-19 8:46 ` Ulrich Hecht
2013-06-19 12:33 ` Simon Horman
2013-06-19 15:08 ` Arnd Bergmann
2013-06-20 12:08 ` Simon Horman
2013-06-17 3:38 ` [PATCH 2/2] ARM: shmobile: r8a7790: don't use external clock for SCIFs Simon Horman
2013-06-17 8:59 ` [GIT PULL 0/2 v2] Renesas sh-sci updates for v3.11 Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-06-17 2:42 [PATCH 0/2] serial: sh-sci: HSCIF support Simon Horman
2013-06-17 2:42 ` [PATCH 1/2] " Simon Horman
2013-06-17 3:00 ` Greg Kroah-Hartman
2013-06-13 7:00 [GIT PULL 0/2] Renesas sh-sci updates for v3.11 Simon Horman
2013-06-13 7:00 ` [PATCH 1/2] serial: sh-sci: HSCIF support Simon Horman
2013-06-15 1:03 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306171454.48936.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox