From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management
Date: Mon, 17 Jun 2013 10:27:52 -0700 [thread overview]
Message-ID: <20130617172751.GT20992@atomide.com> (raw)
In-Reply-To: <CACRpkdZGV7v2=rrKfiLXF7k3JG-1BEDr5=dC+E96gvpnPCCRcQ@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [130617 09:14]:
> On Mon, Jun 17, 2013 at 2:03 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Linus Walleij <linus.walleij@linaro.org> [130617 04:38]:
> >> On Fri, May 31, 2013 at 12:13 PM, Hebbar Gururaja
> >> <gururaja.hebbar@ti.com> wrote:
> >>
> >> > Make pinctrl-single able to handle suspend/resume events and change
> >> > hogged pins states accordingly.
> >> >
> >> > Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com>
> >> > Cc: Linus Walleij <linus.walleij@linaro.org>
> >>
> >> Noone said anything about this patch, but it looks very straight-forward
> >> to me and seems sound so I have applied it.
> >>
> >> If Tony or Haojian has strong feelings about it I will dequeue it.
> >
> > I don't like the hogged pins at all as they prevent me from unloading
> > pinctrl-single.. But the patch seems fine to me:
>
> Hm? I think the hogged pins are the *only* pins we can
> reliably release when unloading the driver, look:
In most cases all the pins can be released reliably if
the pinctrl driver won't do anything with the pins on
release.
After all that's what bootloaders have been doing for
ages :)
> void pinctrl_unregister(struct pinctrl_dev *pctldev)
> {
> (...)
> if (!IS_ERR(pctldev->p))
> pinctrl_put(pctldev->p);
>
> That releases all hogged pinctrl handles when unloading
> a pinctrl driver.
Hmm maybe I need to try it again. The last time I tried
I had to comment those out, but that was a while back.
And I probably had also some other hack to release pins.
Regards,
Tony
next prev parent reply other threads:[~2013-06-17 17:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 10:13 [PATCH 00/11] drivers: Add Pinctrl PM support Hebbar Gururaja
2013-05-31 10:13 ` [PATCH 01/11] pinctrl: single: adopt pinctrl sleep mode management Hebbar Gururaja
2013-06-17 11:32 ` Linus Walleij
2013-06-17 12:03 ` Tony Lindgren
2013-06-17 16:08 ` Linus Walleij
2013-06-17 17:27 ` Tony Lindgren [this message]
2013-05-31 10:13 ` [PATCH 02/11] leds: leds-gpio: Enhance pinctrl support Hebbar Gururaja
2013-06-04 7:18 ` Linus Walleij
2013-05-31 10:13 ` [PATCH 03/11] Input: gpio_keys: Adopt " Hebbar Gururaja
2013-05-31 10:13 ` [PATCH 04/11] Input: matrix-keypad: " Hebbar Gururaja
2013-05-31 10:13 ` [PATCH 05/11] spi: omap2-mcspi: enhance " Hebbar Gururaja
2013-06-01 19:27 ` Mark Brown
2013-06-04 9:53 ` Hebbar, Gururaja
2013-05-31 10:13 ` [PATCH 06/11] usb: musb: dsps: Adopt " Hebbar Gururaja
2013-05-31 10:13 ` [PATCH 07/11] pwm: pwm-tiehrpwm: enhance " Hebbar Gururaja
2013-05-31 10:13 ` [PATCH 08/11] pwm: pwm-tiecap: " Hebbar Gururaja
2013-05-31 10:13 ` [PATCH 09/11] mmc: omap_hsmmc: " Hebbar Gururaja
2013-06-04 7:11 ` Linus Walleij
2013-06-04 7:19 ` Linus Walleij
2013-06-04 9:52 ` Hebbar, Gururaja
2013-06-04 14:46 ` Tony Lindgren
2013-06-07 13:36 ` Balaji T K
2013-06-07 21:01 ` Tony Lindgren
2013-05-31 10:13 ` [PATCH 10/11] video: da8xx-fb: adopt " Hebbar Gururaja
2013-05-31 10:13 ` [PATCH 11/11] i2c: omap: enhance " Hebbar Gururaja
2013-05-31 14:55 ` Grygorii Strashko
2013-06-05 9:04 ` Hebbar, Gururaja
2013-05-31 17:34 ` Kevin Hilman
2013-06-04 11:39 ` Grygorii Strashko
2013-06-05 9:05 ` Hebbar, Gururaja
2013-05-31 18:07 ` Kevin Hilman
2013-06-04 7:23 ` Linus Walleij
2013-06-04 9:50 ` Hebbar, Gururaja
2013-05-31 17:04 ` [PATCH 00/11] drivers: Add Pinctrl PM support Dmitry Torokhov
2013-05-31 18:08 ` Kevin Hilman
2013-06-04 7:25 ` Linus Walleij
2013-06-04 18:15 ` Kevin Hilman
2013-06-04 18:37 ` Mark Brown
2013-06-05 12:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617172751.GT20992@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).