From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clocksource: dw_apb_timer_of: Fix read_sched_clock
Date: Tue, 18 Jun 2013 10:23:33 +0100 [thread overview]
Message-ID: <20130618092333.GA8641@page> (raw)
In-Reply-To: <1371514129-22801-3-git-send-email-dinguyen@altera.com>
Hi Dinh,
On Mon, Jun 17, 2013 at 07:08:49PM -0500, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> The read_sched_clock should return the ~value because the clock is a
> countdown implementation. read_sched_clock() should be the same as
> __apbt_read_clocksource().
>
> If a separate timer for the sched_clock exist, then read_sched_clock()
> will return an incorrect value. The (sched_io_base + 0x4) needs to be in
> the function for both cases.
Actually the old behaviour is correct for picoxcell as we're using the
DesignWare RTC rather than the counter block and the RTC does count
upwards, but your change will work as we'll start using the regular
timers anyway.
Looks good to me though.
Acked-by: Jamie Iles <jamie@jamieiles.com>
for the series.
Jamie
next prev parent reply other threads:[~2013-06-18 9:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 0:08 [PATCH 0/2] Fix potential merge conflict for dw_apb_timer_of dinguyen at altera.com
2013-06-18 0:08 ` [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen at altera.com
2013-06-18 13:11 ` Arnd Bergmann
2013-06-18 0:08 ` [PATCH 2/2] clocksource: dw_apb_timer_of: Fix read_sched_clock dinguyen at altera.com
2013-06-18 9:23 ` Jamie Iles [this message]
2013-06-18 0:38 ` [PATCH 0/2] Fix potential merge conflict for dw_apb_timer_of John Stultz
2013-06-18 2:11 ` Dinh Nguyen
2013-06-18 15:02 ` Pavel Machek
2013-06-18 15:38 ` Heiko Stübner
2013-06-18 18:28 ` Heiko Stübner
2013-06-18 18:40 ` John Stultz
2013-06-18 20:11 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2013-07-25 3:43 [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen at altera.com
2013-07-25 3:43 ` [PATCH 2/2] clocksource: dw_apb_timer_of: Fix read_sched_clock dinguyen at altera.com
2013-07-25 9:02 ` Heiko Stübner
2013-07-25 14:29 ` Dinh Nguyen
2013-07-29 18:30 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618092333.GA8641@page \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).