linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework
Date: Wed, 19 Jun 2013 19:29:25 +0100	[thread overview]
Message-ID: <20130619182925.GL2718@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAAQKjZNJD4HpnJQ7iE+Gez36066M6U0YQeUEdA0+UcSOKqeghg@mail.gmail.com>

On Thu, Jun 20, 2013 at 12:10:04AM +0900, Inki Dae wrote:
> On the other hand, the below shows how we could enhance the conventional
> way with my approach (just example):
> 
> CPU -> DMA,
>         ioctl(qbuf command)              ioctl(streamon)
>               |                                               |
>               |                                               |
>         qbuf  <- dma_buf_sync_get   start streaming <- syncpoint
> 
> dma_buf_sync_get just registers a sync buffer(dmabuf) to sync object. And
> the syncpoint is performed by calling dma_buf_sync_lock(), and then DMA
> accesses the sync buffer.
> 
> And DMA -> CPU,
>         ioctl(dqbuf command)
>               |
>               |
>         dqbuf <- nothing to do
> 
> Actual syncpoint is when DMA operation is completed (in interrupt handler):
> the syncpoint is performed by calling dma_buf_sync_unlock().
> Hence,  my approach is to move the syncpoints into just before dma access
> as long as possible.

What you've just described does *not* work on architectures such as
ARMv7 which do speculative cache fetches from memory at any time that
that memory is mapped with a cacheable status, and will lead to data
corruption.

  parent reply	other threads:[~2013-06-19 18:29 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  8:28 [RFC PATCH] dmabuf-sync: Introduce buffer synchronization framework Inki Dae
2013-06-13 11:25 ` Inki Dae
2013-06-13 17:26 ` Russell King - ARM Linux
2013-06-14  2:32   ` Inki Dae
2013-06-17 11:15 ` [RFC PATCH v2] " Inki Dae
2013-06-17 11:34   ` Maarten Lankhorst
2013-06-17 13:04     ` Inki Dae
2013-06-17 13:31       ` Russell King - ARM Linux
     [not found]         ` <CAAQKjZO_t_kZkU46bUPTpoJs_oE1KkEqS2OTrTYjjJYZzBf+XA@mail.gmail.com>
2013-06-17 15:42           ` Russell King - ARM Linux
2013-06-17 16:01             ` Russell King - ARM Linux
     [not found]             ` <CAAQKjZOokFKN85pygVnm7ShSa+O0ZzwxvQ0rFssgNLp+RO5pGg@mail.gmail.com>
2013-06-17 18:21               ` Russell King - ARM Linux
2013-06-18  5:27                 ` Inki Dae
2013-06-18  8:43                   ` Russell King - ARM Linux
2013-06-18  9:04                     ` Inki Dae
2013-06-18  9:38                       ` Russell King - ARM Linux
2013-06-18  9:47                       ` Lucas Stach
2013-06-19  5:45                         ` Inki Dae
2013-06-19 10:22                           ` Lucas Stach
2013-06-19 10:44                             ` Inki Dae
2013-06-19 12:34                               ` Lucas Stach
     [not found]                                 ` <CAAQKjZNJD4HpnJQ7iE+Gez36066M6U0YQeUEdA0+UcSOKqeghg@mail.gmail.com>
2013-06-19 18:29                                   ` Russell King - ARM Linux [this message]
2013-06-20  6:43                                     ` Inki Dae
2013-06-20  7:47                                       ` Lucas Stach
2013-06-20  8:17                                         ` Russell King - ARM Linux
2013-06-20  8:26                                           ` Lucas Stach
2013-06-20  8:24                                         ` Inki Dae
2013-06-20 10:11                                           ` Lucas Stach
2013-06-20 11:15                                             ` Inki Dae
2013-06-21  8:54                                               ` Lucas Stach
     [not found]                                                 ` <CAAQKjZOxOMuL3zh_yV7tU2LBcZ7oVryiKa+LgjTM5HLY+va8zQ@mail.gmail.com>
2013-06-21 12:27                                                   ` Lucas Stach
2013-06-21 16:55                                                     ` Inki Dae
2013-06-21 19:02                                                       ` Jerome Glisse
     [not found]                                                         ` <CAAQKjZNnJRddACHzD+VF=A8vJpt9SEy2ttnS3Kw0y3hexu8dnw@mail.gmail.com>
2013-06-25 11:32                                                           ` [RFC PATCH] " Rob Clark
2013-06-25 14:17                                                             ` Inki Dae
2013-06-25 14:49                                                               ` Jerome Glisse
2013-06-26 16:06                                                                 ` Inki Dae
2013-06-18  7:00             ` [RFC PATCH v2] " Daniel Vetter
2013-06-18 10:46               ` Russell King - ARM Linux
2013-06-25  9:23                 ` Daniel Vetter
2013-06-26 17:18                   ` Russell King - ARM Linux
2013-06-17 13:31       ` Maarten Lankhorst
2013-06-19  9:10   ` [RFC PATCH v3] " Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130619182925.GL2718@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).