From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Wed, 19 Jun 2013 14:43:29 -0400 Subject: [PATCH] ARM: Kirkwood: Fix the internal register ranges translation In-Reply-To: References: <1371569479-31498-1-git-send-email-ezequiel.garcia@free-electrons.com> <51C0B838.90809@gmail.com> <20130618194756.GA2470@localhost> <20130619183627.GF31667@titan.lakedaemon.net> Message-ID: <20130619184329.GG31667@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 19, 2013 at 03:42:27PM -0300, Ezequiel Garcia wrote: > On Wed, Jun 19, 2013 at 3:36 PM, Jason Cooper wrote: > > On Tue, Jun 18, 2013 at 04:47:57PM -0300, Ezequiel Garcia wrote: > >> On Tue, Jun 18, 2013 at 09:42:48PM +0200, Sebastian Hesselbarth wrote: > >> > On 06/18/2013 05:31 PM, Ezequiel Garcia wrote: > >> > > Although the internal register window size is 1 MiB, the previous > >> > > ranges translation for the internal register space had a size of > >> > > 0x4000000. This was done to allow the crypto and nand node to access > >> > > the corresponding 'sram' and 'nand' decoding windows. > >> > > > >> > > In order to describe the hardware more accurately, we declare the > >> > > real 1 MiB internal register space in the ranges, and add a translation > >> > > entry for the nand node to access the 'nand' window. > >> > > > >> > > This commit will make future improvements on the MBus DT binding easier. > >> > > > >> > > Signed-off-by: Ezequiel Garcia > >> > > --- > >> > > Tested on Plathome Openblocks A6 board. > >> > > > >> > > arch/arm/boot/dts/kirkwood.dtsi | 5 +++-- > >> > > 1 file changed, 3 insertions(+), 2 deletions(-) > >> > > > >> > > diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi > >> > > index 8a1e3bb..910fabc 100644 > >> > > --- a/arch/arm/boot/dts/kirkwood.dtsi > >> > > +++ b/arch/arm/boot/dts/kirkwood.dtsi > >> > > @@ -38,7 +38,8 @@ > >> > > > >> > > ocp at f1000000 { > >> > > compatible = "simple-bus"; > >> > > - ranges =<0x00000000 0xf1000000 0x4000000 > >> > > + ranges =<0x00000000 0xf1000000 0x0100000 > >> > > + 0xf4000000 0xf4000000 0x0000400 > >> > > 0xf5000000 0xf5000000 0x0000400>; > >> > > >> > Ezequiel, > >> > > >> > maybe you should also put a comment at the end of each ranges > >> > line to name the remap it does? > >> > > >> > Also, as already mentioned on IRC, it would be great to also > >> > have dove.dtsi updated accordingly. > >> > > >> > >> Indeed, I will do both. > > > > The sooner, the better. This is probably the last patch to get in for > > this merge window for mvebu... > > > > Right. Please don't wait for this patch if it's not in your mailbox by tomorrow. Ok. thx, Jason.