* [PATCH] perf: arm64: Record the user-mode PC in the call chain.
@ 2013-06-20 3:07 Jed Davis
2013-06-20 8:33 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Jed Davis @ 2013-06-20 3:07 UTC (permalink / raw)
To: linux-arm-kernel
With this change, we no longer lose the innermost entry in the user-mode
part of the call chain. See also the x86 port, which includes the ip,
and the corresponding change in arch/arm.
Signed-off-by: Jed Davis <jld@mozilla.com>
---
arch/arm64/kernel/perf_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 1e49e5eb..9ba33c4 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
return;
}
+ perf_callchain_store(entry, regs->pc);
tail = (struct frame_tail __user *)regs->regs[29];
while (entry->nr < PERF_MAX_STACK_DEPTH &&
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] perf: arm64: Record the user-mode PC in the call chain.
2013-06-20 3:07 [PATCH] perf: arm64: Record the user-mode PC in the call chain Jed Davis
@ 2013-06-20 8:33 ` Ingo Molnar
2013-06-20 9:11 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2013-06-20 8:33 UTC (permalink / raw)
To: linux-arm-kernel
* Jed Davis <jld@mozilla.com> wrote:
> With this change, we no longer lose the innermost entry in the user-mode
> part of the call chain. See also the x86 port, which includes the ip,
> and the corresponding change in arch/arm.
>
> Signed-off-by: Jed Davis <jld@mozilla.com>
> ---
> arch/arm64/kernel/perf_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 1e49e5eb..9ba33c4 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
> return;
> }
>
> + perf_callchain_store(entry, regs->pc);
> tail = (struct frame_tail __user *)regs->regs[29];
>
> while (entry->nr < PERF_MAX_STACK_DEPTH &&
Acked-by: Ingo Molnar <mingo@kernel.org>
I suspect this goes to v3.10 via the ARM64 tree?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] perf: arm64: Record the user-mode PC in the call chain.
2013-06-20 8:33 ` Ingo Molnar
@ 2013-06-20 9:11 ` Will Deacon
0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2013-06-20 9:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 20, 2013 at 09:33:28AM +0100, Ingo Molnar wrote:
>
> * Jed Davis <jld@mozilla.com> wrote:
>
> > With this change, we no longer lose the innermost entry in the user-mode
> > part of the call chain. See also the x86 port, which includes the ip,
> > and the corresponding change in arch/arm.
> >
> > Signed-off-by: Jed Davis <jld@mozilla.com>
> > ---
> > arch/arm64/kernel/perf_event.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> > index 1e49e5eb..9ba33c4 100644
> > --- a/arch/arm64/kernel/perf_event.c
> > +++ b/arch/arm64/kernel/perf_event.c
> > @@ -1336,6 +1336,7 @@ void perf_callchain_user(struct perf_callchain_entry *entry,
> > return;
> > }
> >
> > + perf_callchain_store(entry, regs->pc);
> > tail = (struct frame_tail __user *)regs->regs[29];
> >
> > while (entry->nr < PERF_MAX_STACK_DEPTH &&
>
> Acked-by: Ingo Molnar <mingo@kernel.org>
>
> I suspect this goes to v3.10 via the ARM64 tree?
Yup, we'll take this via the arm64 tree, thanks.
Catalin, you can add:
Acked-by: Will Deacon <will.deacon@arm.com>
to this.
Cheers,
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-20 9:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-20 3:07 [PATCH] perf: arm64: Record the user-mode PC in the call chain Jed Davis
2013-06-20 8:33 ` Ingo Molnar
2013-06-20 9:11 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).