From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] picoxcell cleanups for 3.11
Date: Thu, 20 Jun 2013 15:57:44 +0100 [thread overview]
Message-ID: <20130620145744.GC8641@page> (raw)
In-Reply-To: <201306201624.09841.arnd@arndb.de>
Hi Arnd,
On Thu, Jun 20, 2013 at 04:24:09PM +0200, Arnd Bergmann wrote:
> On Wednesday 19 June 2013, Jamie Iles wrote:
> > Fixing Arnd's mail address (sorry!).
>
> you did forget to fix up Olof's address though.
Gah, fat fingers!
> > > ----------------------------------------------------------------
> > > Jamie Iles (1):
> > > picoxcell: remove redundant common.h
> > >
> > > Maxime Ripard (1):
> > > ARM: picoxcell: Remove init_irq declaration in machine description
>
> I got a regression since NR_IRQS_LEGACY is not defined with the headers
> removed.
>
> I think we can just remove this line as well, since NR_IRQS_LEGACY is
> the default anyway.
>
> Does that work?
I can't reproduce the failure here with my config, I guess it's getting
included through one of the other includes. Either way, your fix looks
good to me.
Thanks,
Jamie
> diff --git a/arch/arm/mach-picoxcell/common.c b/arch/arm/mach-picoxcell/common.c
> index 8267c5d..b13f51b 100644
> --- a/arch/arm/mach-picoxcell/common.c
> +++ b/arch/arm/mach-picoxcell/common.c
> @@ -79,7 +79,6 @@ static void picoxcell_wdt_restart(char mode, const char *cmd)
>
> DT_MACHINE_START(PICOXCELL, "Picochip picoXcell")
> .map_io = picoxcell_map_io,
> - .nr_irqs = NR_IRQS_LEGACY,
> .init_machine = picoxcell_init_machine,
> .dt_compat = picoxcell_dt_match,
> .restart = picoxcell_wdt_restart,
next prev parent reply other threads:[~2013-06-20 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 12:26 [GIT PULL] picoxcell cleanups for 3.11 Jamie Iles
2013-06-19 10:02 ` Jamie Iles
2013-06-20 13:31 ` Arnd Bergmann
2013-06-20 14:24 ` Arnd Bergmann
2013-06-20 14:57 ` Jamie Iles [this message]
2013-06-20 18:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620145744.GC8641@page \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).