From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c
Date: Fri, 21 Jun 2013 11:18:36 -0600 [thread overview]
Message-ID: <20130621171836.GC10905@obsidianresearch.com> (raw)
In-Reply-To: <51C46001.30500@gmail.com>
On Fri, Jun 21, 2013 at 04:15:29PM +0200, Sebastian Hesselbarth wrote:
> from a quick check of the patch set (which you forgot to send to LKML)
> I am wondering why you didn't update the of matches struct with the new
> compatible for "marvell,mv78230-i2c"? This will save you from still
> having "marvell,mv64xxx-i2c" as additional compatible to match device
> and driver. With that the above should also be s/and/or/.
Agree, I noticed the same things.
Alos, the compatible string should be:
compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
(note the order reversal, most specific is first)
and I think it is better to use the 'data' field of of_device_id than
a of_is_compatible call. The former is sensitive to order of the
compatible string, the latter is not.
Jason
next prev parent reply other threads:[~2013-06-21 17:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 13:32 [PATCH v3 0/4] i2c-mv64xxx: Fixes and new feature for controlers embedded in Aramda XP Gregory CLEMENT
2013-06-21 13:32 ` [PATCH v3 1/4] i2c-mv64xxx: Set bus frequency to 100kHz if clock-frequency is not provided Gregory CLEMENT
2013-06-25 21:44 ` Wolfram Sang
2013-06-26 7:55 ` Gregory CLEMENT
2013-06-26 13:41 ` Wolfram Sang
2013-06-21 13:32 ` [PATCH v3 2/4] i2c-mv64xxx: Add I2C Transaction Generator support Gregory CLEMENT
2013-06-21 13:32 ` [PATCH v3 3/4] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889) Gregory CLEMENT
2013-06-21 13:32 ` [PATCH v3 4/4] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c Gregory CLEMENT
2013-06-21 14:07 ` Jason Cooper
2013-06-21 14:15 ` Sebastian Hesselbarth
2013-06-21 14:23 ` Gregory CLEMENT
2013-06-21 14:56 ` Jason Cooper
2013-06-21 15:03 ` Wolfram Sang
2013-06-21 15:06 ` Jason Cooper
2013-06-21 17:18 ` Jason Gunthorpe [this message]
2013-06-22 16:14 ` Sebastian Hesselbarth
2013-06-24 9:54 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621171836.GC10905@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).