From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap5: build opp4xxx_data.c
Date: Fri, 21 Jun 2013 15:42:50 -0500 [thread overview]
Message-ID: <20130621204250.GA16139@kahuna> (raw)
In-Reply-To: <201306212229.54238.arnd@arndb.de>
On 22:29-20130621, Arnd Bergmann wrote:
> Building OMAP5 support without this file currently results in this link error:
>
> arch/arm/mach-omap2/built-in.o: In function `omap54xx_voltagedomains_init':
> :(.init.text+0x6b80): undefined reference to `omap446x_vdd_core_volt_data'
> :(.init.text+0x6b84): undefined reference to `omap446x_vdd_mpu_volt_data'
> :(.init.text+0x6b88): undefined reference to `omap446x_vdd_iva_volt_data'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap at vger.kernel.org
>
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index 0520dc4..f5038f5 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -77,6 +77,7 @@ ifeq ($(CONFIG_PM_OPP),y)
> obj-y += opp.o
> obj-$(CONFIG_ARCH_OMAP3) += opp3xxx_data.o
> obj-$(CONFIG_ARCH_OMAP4) += opp4xxx_data.o
> +obj-$(CONFIG_SOC_OMAP5) += opp4xxx_data.o
> endif
>
/*
* XXX Will depend on the process, validation, and binning
* for the currently-running IC. Use OMAP4 data for time being.
*/
#ifdef CONFIG_PM_OPP
omap5_voltdm_mpu.volt_data = omap446x_vdd_mpu_volt_data;
omap5_voltdm_mm.volt_data = omap446x_vdd_iva_volt_data;
omap5_voltdm_core.volt_data = omap446x_vdd_core_volt_data;
#endif
Should we just remove this instead? these are obviously wrong.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-06-21 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 20:29 [PATCH] ARM: omap5: build opp4xxx_data.c Arnd Bergmann
2013-06-21 20:42 ` Nishanth Menon [this message]
2013-06-25 19:20 ` Paul Walmsley
2013-06-25 19:55 ` Santosh Shilimkar
2013-06-25 19:57 ` Nishanth Menon
2013-06-25 20:12 ` Santosh Shilimkar
2013-06-25 20:17 ` Nishanth Menon
2013-06-25 20:24 ` Santosh Shilimkar
2013-06-25 20:56 ` Kevin Hilman
2013-06-25 20:59 ` Santosh Shilimkar
2013-06-25 22:36 ` Nishanth Menon
2013-06-25 22:43 ` Santosh Shilimkar
2013-06-25 23:02 ` Nishanth Menon
2013-06-25 23:27 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621204250.GA16139@kahuna \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).