[patch 1/1] imx53-qsb: enable usb power

[patch 1/1] imx53-qsb: enable usb power

[Arnaud Patard (Rtp)]

An embedded and charset-unspecified text was scrubbed...
Name: imx53-qsb-usb-power.patch
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130620/749dd8d2/attachment.ksh>

[patch 1/1] imx53-qsb: enable usb power

[Sascha Hauer]

On Thu, Jun 20, 2013 at 11:29:30PM +0200, Arnaud Patard wrote:
> Enable usb power pin by using a fixed regulator. With this and the usb clock
> patch is making usb working on my loco.
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> Index: linux-next/arch/arm/boot/dts/imx53-qsb.dts
> ===================================================================
> --- linux-next.orig/arch/arm/boot/dts/imx53-qsb.dts	2013-06-20 23:25:46.049428530 +0200
> +++ linux-next/arch/arm/boot/dts/imx53-qsb.dts	2013-06-20 23:26:34.293425920 +0200
> @@ -93,6 +93,15 @@
>  			regulator-max-microvolt = <3200000>;
>  			regulator-always-on;
>  		};
> +
> +		reg_usbpwr: usbpwr {
> +			compatible = "regulator-fixed";
> +			regulator-name = "usbpwr";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			gpio = <&gpio7 8 0>;
> +			regulator-always-on;
> +		};

Shouldn't this be provided to the chipidea driver as vbus?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[patch 1/1] imx53-qsb: enable usb power

[Arnaud Patard (Rtp)]

Sascha Hauer <s.hauer@pengutronix.de> writes:

> On Thu, Jun 20, 2013 at 11:29:30PM +0200, Arnaud Patard wrote:
>> Enable usb power pin by using a fixed regulator. With this and the usb clock
>> patch is making usb working on my loco.
>> 
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>> Index: linux-next/arch/arm/boot/dts/imx53-qsb.dts
>> ===================================================================
>> --- linux-next.orig/arch/arm/boot/dts/imx53-qsb.dts	2013-06-20 23:25:46.049428530 +0200
>> +++ linux-next/arch/arm/boot/dts/imx53-qsb.dts	2013-06-20 23:26:34.293425920 +0200
>> @@ -93,6 +93,15 @@
>>  			regulator-max-microvolt = <3200000>;
>>  			regulator-always-on;
>>  		};
>> +
>> +		reg_usbpwr: usbpwr {
>> +			compatible = "regulator-fixed";
>> +			regulator-name = "usbpwr";
>> +			regulator-min-microvolt = <5000000>;
>> +			regulator-max-microvolt = <5000000>;
>> +			gpio = <&gpio7 8 0>;
>> +			regulator-always-on;
>> +		};
>
> Shouldn't this be provided to the chipidea driver as vbus?

I'm not sure about that. This gpio is controlling the usb power for the
2 usb ports while the vbus is more a port-basis thing.

Arnaud

[patch 1/1] imx53-qsb: enable usb power

[Fabio Estevam]

On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
> Enable usb power pin by using a fixed regulator. With this and the usb clock
> patch is making usb working on my loco.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>

Could you please test this against linux-next?

It does not work for me:

usbcore: registered new interface driver usb-storage
platform 53f80000.usb: Driver imx_usb requests probe deferral
platform 53f80200.usb: Driver imx_usb requests probe deferral

[patch 1/1] imx53-qsb: enable usb power

[Fabio Estevam]

On Mon, Jun 24, 2013 at 8:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
> <arnaud.patard@rtp-net.org> wrote:
>> Enable usb power pin by using a fixed regulator. With this and the usb clock
>> patch is making usb working on my loco.
>>
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>
> Could you please test this against linux-next?
>
> It does not work for me:
>
> usbcore: registered new interface driver usb-storage
> platform 53f80000.usb: Driver imx_usb requests probe deferral
> platform 53f80200.usb: Driver imx_usb requests probe deferral

Ok, got it working now, but had to do two changes:

- Add a vbus-supply node for usbh1 as suggested by Sascha

- Select CONFIG_NOP_USB_XCEIV. Will send a patch to select it by default.

[patch 1/1] imx53-qsb: enable usb power

[Arnaud Patard (Rtp)]

Fabio Estevam <festevam@gmail.com> writes:

> On Mon, Jun 24, 2013 at 8:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
>> <arnaud.patard@rtp-net.org> wrote:
>>> Enable usb power pin by using a fixed regulator. With this and the usb clock
>>> patch is making usb working on my loco.
>>>
>>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>>
>> Could you please test this against linux-next?
>>
>> It does not work for me:
>>
>> usbcore: registered new interface driver usb-storage
>> platform 53f80000.usb: Driver imx_usb requests probe deferral
>> platform 53f80200.usb: Driver imx_usb requests probe deferral
>
> Ok, got it working now, but had to do two changes:
>
> - Add a vbus-supply node for usbh1 as suggested by Sascha

How do you want to proceed ? send a patch on top of mine or send a new
patch containing my patch and this change ? ( I guess that the later
would be easier)

btw, now that it seems that some more stuff has been merged in chipidea
are in next, what about enabling the second port ?

Arnaud

[patch 1/1] imx53-qsb: enable usb power

[Fabio Estevam]

On Tue, Jun 25, 2013 at 2:08 PM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:

> How do you want to proceed ? send a patch on top of mine or send a new
> patch containing my patch and this change ? ( I guess that the later
> would be easier)

It would be nice if you could send a v2 of your patch adding the
vbus_supply node.
>
> btw, now that it seems that some more stuff has been merged in chipidea
> are in next, what about enabling the second port ?

That would be nice as well, please send a patch for it if you have a chance.

[patch 1/1] imx53-qsb: enable usb power

[Fabio Estevam]

On Thu, Jun 20, 2013 at 6:29 PM, Arnaud Patard
<arnaud.patard@rtp-net.org> wrote:
> Enable usb power pin by using a fixed regulator. With this and the usb clock
> patch is making usb working on my loco.

Which "usb clock patch" are you referring to?