* [PATCH] ARM: Fix dtb dependency to use order-only prerequisites
@ 2013-06-24 20:41 Doug Anderson
2013-06-24 20:45 ` Olof Johansson
2013-06-24 20:55 ` David Brown
0 siblings, 2 replies; 3+ messages in thread
From: Doug Anderson @ 2013-06-24 20:41 UTC (permalink / raw)
To: linux-arm-kernel
The %.dtb dependency is specified to depend on the PHONY "scripts".
That means that it'll build every time even if the underlying dtb file
hasn't been touched. Use an order-only prerequisites to fix this.
Also mark "dtbs" as PHONY for correctness.
This was broken in (70b0476 ARM: 7513/1: Make sure dtc is built before
running it).
Reported-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
arch/arm/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 1ba358b..fe8144e 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -289,9 +289,10 @@ zImage Image xipImage bootpImage uImage: vmlinux
zinstall uinstall install: vmlinux
$(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@
-%.dtb: scripts
+%.dtb: | scripts
$(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@
+PHONY += dtbs
dtbs: scripts
$(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) dtbs
--
1.8.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: Fix dtb dependency to use order-only prerequisites
2013-06-24 20:41 [PATCH] ARM: Fix dtb dependency to use order-only prerequisites Doug Anderson
@ 2013-06-24 20:45 ` Olof Johansson
2013-06-24 20:55 ` David Brown
1 sibling, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2013-06-24 20:45 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 24, 2013 at 1:41 PM, Doug Anderson <dianders@chromium.org> wrote:
> The %.dtb dependency is specified to depend on the PHONY "scripts".
> That means that it'll build every time even if the underlying dtb file
> hasn't been touched. Use an order-only prerequisites to fix this.
> Also mark "dtbs" as PHONY for correctness.
>
> This was broken in (70b0476 ARM: 7513/1: Make sure dtc is built before
> running it).
>
> Reported-by: Mike Frysinger <vapier@gentoo.org>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Olof Johansson <olof@lixom.net>
Please send to Russell's patch tracker.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: Fix dtb dependency to use order-only prerequisites
2013-06-24 20:41 [PATCH] ARM: Fix dtb dependency to use order-only prerequisites Doug Anderson
2013-06-24 20:45 ` Olof Johansson
@ 2013-06-24 20:55 ` David Brown
1 sibling, 0 replies; 3+ messages in thread
From: David Brown @ 2013-06-24 20:55 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 24, 2013 at 01:41:57PM -0700, Doug Anderson wrote:
>The %.dtb dependency is specified to depend on the PHONY "scripts".
>That means that it'll build every time even if the underlying dtb file
>hasn't been touched. Use an order-only prerequisites to fix this.
>Also mark "dtbs" as PHONY for correctness.
>
>This was broken in (70b0476 ARM: 7513/1: Make sure dtc is built before
>running it).
>
>Reported-by: Mike Frysinger <vapier@gentoo.org>
>Signed-off-by: Doug Anderson <dianders@chromium.org>
>---
> arch/arm/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: David Brown <davidb@codeaurora.org>
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-24 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-24 20:41 [PATCH] ARM: Fix dtb dependency to use order-only prerequisites Doug Anderson
2013-06-24 20:45 ` Olof Johansson
2013-06-24 20:55 ` David Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).