[PATCH] spi: sirf: add missed spi mode_bits that SiRFSoC hardware supports

[PATCH] spi: sirf: add missed spi mode_bits that SiRFSoC hardware supports

[Barry Song]

From: Qipan Li <Qipan.Li@csr.com>

Missing this will cause some user cases fail when they want to change spi
transfer mode.

Signed-off-by: Qipan Li <Qipan.Li@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
 rebased to for-next branch of broonie/spi.git

 drivers/spi/spi-sirf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-sirf.c b/drivers/spi/spi-sirf.c
index fc20bcf..9608716 100644
--- a/drivers/spi/spi-sirf.c
+++ b/drivers/spi/spi-sirf.c
@@ -538,6 +538,7 @@ static int spi_sirfsoc_probe(struct platform_device *pdev)
 	sspi->bitbang.txrx_bufs = spi_sirfsoc_transfer;
 	sspi->bitbang.master->setup = spi_sirfsoc_setup;
 	master->bus_num = pdev->id;
+	master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST | SPI_CS_HIGH;
 	master->bits_per_word_mask = SPI_BPW_MASK(8) | SPI_BPW_MASK(12) |
 					SPI_BPW_MASK(16) | SPI_BPW_MASK(32);
 	sspi->bitbang.master->dev.of_node = pdev->dev.of_node;
-- 
1.8.2.3



Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog

[PATCH] spi: sirf: add missed spi mode_bits that SiRFSoC hardware supports

[Mark Brown]

On Tue, Jun 25, 2013 at 07:45:29PM +0800, Barry Song wrote:
> From: Qipan Li <Qipan.Li@csr.com>
> 
> Missing this will cause some user cases fail when they want to change spi
> transfer mode.

This doesn't seem to apply against the current SPI code or mainline -
can you please check and resend?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130625/a3e10f12/attachment.sig>

[PATCH] spi: sirf: add missed spi mode_bits that SiRFSoC hardware supports

[Barry Song]

2013/6/25 Mark Brown <broonie@kernel.org>:
> On Tue, Jun 25, 2013 at 07:45:29PM +0800, Barry Song wrote:
>> From: Qipan Li <Qipan.Li@csr.com>
>>
>> Missing this will cause some user cases fail when they want to change spi
>> transfer mode.
>
> This doesn't seem to apply against the current SPI code or mainline -
> can you please check and resend?

this was againest your for-next branch of spi as i guessed it will be
in the coming version. you want one againest mainline?

-barry

[PATCH] spi: sirf: add missed spi mode_bits that SiRFSoC hardware supports

[Mark Brown]

On Wed, Jun 26, 2013 at 12:17:24AM +0800, Barry Song wrote:

> this was againest your for-next branch of spi as i guessed it will be
> in the coming version. you want one againest mainline?

I'm looking for things against topic/sirf.  Just checked again and it's
due to a dependency on topic/bpw.  I've merged that in and applied,
thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/4e17af80/attachment-0001.sig>