* [PATCH 02/23] ARM: dt: tegra30: iommu: Add "nvidia,swgroups"
@ 2013-06-26 9:28 Hiroshi Doyu
2013-06-26 10:24 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Hiroshi Doyu @ 2013-06-26 9:28 UTC (permalink / raw)
To: linux-arm-kernel
This is a bitmap that indicates which HardWare Accelerators(HWA) are
supported on Tegra30 SoC.
Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
---
Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt | 6 +++++-
arch/arm/boot/dts/tegra30.dtsi | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt b/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt
index 89fb543..6be51f6 100644
--- a/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt
+++ b/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt
@@ -8,14 +8,18 @@ Required properties:
- nvidia,#asids : # of ASIDs
- dma-window : IOVA start address and length.
- nvidia,ahb : phandle to the ahb bus connected to SMMU.
+- nvidia,swgroups: A bit map of supported HardWare Accelerators(HWA).
+ Each bit represents one sgroup. The assignments may be found in header
+ file <dt-bindings/iommu/tegra-swgid.h>.
Example:
- smmu {
+ iommu {
compatible = "nvidia,tegra30-smmu";
reg = <0x7000f010 0x02c
0x7000f1f0 0x010
0x7000f228 0x05c>;
nvidia,#asids = <4>; /* # of ASIDs */
dma-window = <0 0x40000000>; /* IOVA start & length */
+ nvidia,swgroups = <0x00000000 0x000779ff>;
nvidia,ahb = <&ahb>;
};
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
index d8783f0..14ec3f9 100644
--- a/arch/arm/boot/dts/tegra30.dtsi
+++ b/arch/arm/boot/dts/tegra30.dtsi
@@ -461,6 +461,7 @@
0x7000f228 0x05c>;
nvidia,#asids = <4>; /* # of ASIDs */
dma-window = <0 0x40000000>; /* IOVA start & length */
+ nvidia,swgroups = <0x00000000 0x000779ff>;
nvidia,ahb = <&ahb>;
};
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 02/23] ARM: dt: tegra30: iommu: Add "nvidia,swgroups"
2013-06-26 9:28 [PATCH 02/23] ARM: dt: tegra30: iommu: Add "nvidia,swgroups" Hiroshi Doyu
@ 2013-06-26 10:24 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2013-06-26 10:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 26, 2013 at 12:28:05PM +0300, Hiroshi Doyu wrote:
> This is a bitmap that indicates which HardWare Accelerators(HWA) are
> supported on Tegra30 SoC.
>
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> ---
> Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt | 6 +++++-
> arch/arm/boot/dts/tegra30.dtsi | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt b/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt
> index 89fb543..6be51f6 100644
> --- a/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt
> +++ b/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt
> @@ -8,14 +8,18 @@ Required properties:
> - nvidia,#asids : # of ASIDs
> - dma-window : IOVA start address and length.
> - nvidia,ahb : phandle to the ahb bus connected to SMMU.
> +- nvidia,swgroups: A bit map of supported HardWare Accelerators(HWA).
Nit: you use the spelling "bitmap" in the subject but "bit map" here.
Both are correct but perhaps we should stick to one.
> + Each bit represents one sgroup. The assignments may be found in header
Nit: "swgroup"
> - smmu {
> + iommu {
This change isn't really related, but given that the tegra30.dtsi
already uses it I guess we can keep it as part of this patch.
> compatible = "nvidia,tegra30-smmu";
> reg = <0x7000f010 0x02c
> 0x7000f1f0 0x010
> 0x7000f228 0x05c>;
> nvidia,#asids = <4>; /* # of ASIDs */
> dma-window = <0 0x40000000>; /* IOVA start & length */
> + nvidia,swgroups = <0x00000000 0x000779ff>;
Perhaps this should be a symbolic name too? Perhaps something like
TEGRA30_SWGID_ALL?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/09d59650/attachment-0001.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-26 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 9:28 [PATCH 02/23] ARM: dt: tegra30: iommu: Add "nvidia,swgroups" Hiroshi Doyu
2013-06-26 10:24 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).