* [PATCH 06/23] ARM: dt: tegra114: iommu: Add "nvidia,swgroups"
@ 2013-06-26 9:28 Hiroshi Doyu
2013-06-26 10:52 ` Thierry Reding
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Doyu @ 2013-06-26 9:28 UTC (permalink / raw)
To: linux-arm-kernel
This is a bitmap that indicates which HardWare Accelerators(HWA) are
supported on Tegra114 SoC.
Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
---
arch/arm/boot/dts/tegra114.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index 1f45cf5..715b5d6 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -323,7 +323,7 @@
0x70019228 0x074>;
nvidia,#asids = <4>;
dma-window = <0 0x40000000>;
- nvidia,swgroups = <0x18659fe>;
+ nvidia,swgroups = <0x00000000 0x01b659fe>;
nvidia,ahb = <&ahb>;
};
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 06/23] ARM: dt: tegra114: iommu: Add "nvidia,swgroups"
2013-06-26 9:28 [PATCH 06/23] ARM: dt: tegra114: iommu: Add "nvidia,swgroups" Hiroshi Doyu
@ 2013-06-26 10:52 ` Thierry Reding
2013-07-01 8:24 ` Hiroshi Doyu
0 siblings, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2013-06-26 10:52 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 26, 2013 at 12:28:09PM +0300, Hiroshi Doyu wrote:
> This is a bitmap that indicates which HardWare Accelerators(HWA) are
> supported on Tegra114 SoC.
>
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> ---
> arch/arm/boot/dts/tegra114.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index 1f45cf5..715b5d6 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -323,7 +323,7 @@
> 0x70019228 0x074>;
> nvidia,#asids = <4>;
> dma-window = <0 0x40000000>;
> - nvidia,swgroups = <0x18659fe>;
> + nvidia,swgroups = <0x00000000 0x01b659fe>;
> nvidia,ahb = <&ahb>;
> };
It seems like an nvidia,tegra114-smmu.txt file is missing from the
Documentation/devicetree/bindings/iommu directory. And similarily to my
comment for the tegra30.dtsi update this could be a symbolic value such
as TEGRA114_SWGID_ALL.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130626/fdd17edb/attachment-0001.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 06/23] ARM: dt: tegra114: iommu: Add "nvidia,swgroups"
2013-06-26 10:52 ` Thierry Reding
@ 2013-07-01 8:24 ` Hiroshi Doyu
2013-07-01 23:10 ` Stephen Warren
0 siblings, 1 reply; 4+ messages in thread
From: Hiroshi Doyu @ 2013-07-01 8:24 UTC (permalink / raw)
To: linux-arm-kernel
Thierry Reding <thierry.reding@gmail.com> wrote @ Wed, 26 Jun 2013 12:52:17 +0200:
> * PGP Signed by an unknown key
>
> On Wed, Jun 26, 2013 at 12:28:09PM +0300, Hiroshi Doyu wrote:
> > This is a bitmap that indicates which HardWare Accelerators(HWA) are
> > supported on Tegra114 SoC.
> >
> > Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> > ---
> > arch/arm/boot/dts/tegra114.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> > index 1f45cf5..715b5d6 100644
> > --- a/arch/arm/boot/dts/tegra114.dtsi
> > +++ b/arch/arm/boot/dts/tegra114.dtsi
> > @@ -323,7 +323,7 @@
> > 0x70019228 0x074>;
> > nvidia,#asids = <4>;
> > dma-window = <0 0x40000000>;
> > - nvidia,swgroups = <0x18659fe>;
> > + nvidia,swgroups = <0x00000000 0x01b659fe>;
> > nvidia,ahb = <&ahb>;
> > };
>
> It seems like an nvidia,tegra114-smmu.txt file is missing from the
> Documentation/devicetree/bindings/iommu directory.
All difference between T30 and T114 is now provided from DT. They have
all same entries but only those values are different.
Do we still need a copy of nvidia,tegra30-smmu.txt for t114 or is just
tweaking nvidia,tegra30-smmu.txt for t114 enough?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 06/23] ARM: dt: tegra114: iommu: Add "nvidia,swgroups"
2013-07-01 8:24 ` Hiroshi Doyu
@ 2013-07-01 23:10 ` Stephen Warren
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2013-07-01 23:10 UTC (permalink / raw)
To: linux-arm-kernel
On 07/01/2013 02:24 AM, Hiroshi Doyu wrote:
> Thierry Reding <thierry.reding@gmail.com> wrote @ Wed, 26 Jun 2013 12:52:17 +0200:
>> On Wed, Jun 26, 2013 at 12:28:09PM +0300, Hiroshi Doyu wrote:
>>> This is a bitmap that indicates which HardWare Accelerators(HWA) are
>>> supported on Tegra114 SoC.
...
>> It seems like an nvidia,tegra114-smmu.txt file is missing from the
>> Documentation/devicetree/bindings/iommu directory.
>
> All difference between T30 and T114 is now provided from DT. They have
> all same entries but only those values are different.
>
> Do we still need a copy of nvidia,tegra30-smmu.txt for t114 or is just
> tweaking nvidia,tegra30-smmu.txt for t114 enough?
If the two HW are identical (at least as far as bindings), the existing
nvidia,tegra30-smmu.txt should be enough. We probably should at least
update it to list the additional supported compatible value though,
especially if the driver interprets the two compatible values in a
different way (e.g. there are HW differences, but they don't affect the
binding definition).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-01 23:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 9:28 [PATCH 06/23] ARM: dt: tegra114: iommu: Add "nvidia,swgroups" Hiroshi Doyu
2013-06-26 10:52 ` Thierry Reding
2013-07-01 8:24 ` Hiroshi Doyu
2013-07-01 23:10 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).