From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
Date: Wed, 26 Jun 2013 23:52:52 +0900 [thread overview]
Message-ID: <20130626145252.GA4748@verge.net.au> (raw)
In-Reply-To: <1642514.quKgForQrD@amdc1032>
[ Cc linux-sh and Guennadi ]
I have not looked into this closely but it seems to me that
it would be more robust to resolve this problem using Kconfig.
On Wed, Jun 26, 2013 at 12:02:55PM +0200, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
>
> Building marzen_defconfig for next-20130626 results in the following
> build error:
>
> drivers/built-in.o: In function `sh_mobile_sdhi_probe':
> /home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'
>
> Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This
> will result in CONFIG_SH_DMAE_BASE being enabled by default and the
> needed code being build.
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> arch/arm/configs/marzen_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: b/arch/arm/configs/marzen_defconfig
> ===================================================================
> --- a/arch/arm/configs/marzen_defconfig 2013-06-21 12:04:24.813681807 +0200
> +++ b/arch/arm/configs/marzen_defconfig 2013-06-25 16:43:40.730367398 +0200
> @@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_GPIO=y
> +CONFIG_DMADEVICES=y
> CONFIG_UIO=y
> CONFIG_UIO_PDRV_GENIRQ=y
> # CONFIG_IOMMU_SUPPORT is not set
>
next prev parent reply other threads:[~2013-06-26 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 10:02 [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support Bartlomiej Zolnierkiewicz
2013-06-26 14:52 ` Simon Horman [this message]
2013-06-26 15:01 ` Guennadi Liakhovetski
2013-06-27 5:00 ` Simon Horman
2013-06-27 9:05 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130626145252.GA4748@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).