From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: amba-pl08x and 'get_signal' namespace collision/build error
Date: Thu, 27 Jun 2013 10:46:51 +0100 [thread overview]
Message-ID: <20130627094650.GC4283@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130626103930.GS23141@intel.com>
On Wed, Jun 26, 2013 at 04:09:30PM +0530, Vinod Koul wrote:
> On Wed, Jun 26, 2013 at 09:19:09AM +0100, Russell King - ARM Linux wrote:
> > On Wed, Jun 26, 2013 at 10:18:42AM +0530, Vinod Koul wrote:
> > > Yup. This is fixed in slave-dma tree by a patch from mark by renaming it.
> > >
> > > This should not show in the -next tree
> >
> > Except, that change probably is probably responsible for this new error:
> >
> > drivers/dma/amba-pl08x.c: In function 'pl08x_request_mux':
> > drivers/dma/amba-pl08x.c:304:13: error: expected identifier before '(' token
> This was pushed four days ago and havent seen any error report expect this.
>
> Anyway I rebuild my -next and looks fine for me
>
> CC drivers/dma/dmaengine.o
> CC drivers/dma/virt-dma.o
> CC drivers/dma/iovlock.o
> CC [M] drivers/dma/dmatest.o
> CC drivers/dma/amba-pl08x.o
> LD drivers/dma/built-in.o
>
> Can you share your config which failed for you?
>
> Mark, I believe you are testing for this, have you seen above error?
Right, what's going on is that I have a commit in my tree which adds an
include to asm/pgtable.h which introduces a #define for get_signal.
This becomes visible to amba-pl08x.c.
However, my build test tree fails *every* time because what I'm building
is Linus' tree, my tree plus arm-soc, and it doesn't include your tree.
This makes my build testing for the next merge window impossible.
So, I need the fix to pl08x.c merged into my tree.
next prev parent reply other threads:[~2013-06-27 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 11:30 amba-pl08x and 'get_signal' namespace collision/build error Jonathan Austin
2013-06-25 13:49 ` Linus Walleij
2013-06-25 18:45 ` Russell King - ARM Linux
2013-06-26 4:48 ` Vinod Koul
2013-06-26 8:19 ` Russell King - ARM Linux
2013-06-26 10:39 ` Vinod Koul
2013-06-26 12:00 ` Mark Brown
2013-06-27 9:46 ` Russell King - ARM Linux [this message]
2013-07-03 18:27 ` Olof Johansson
2013-07-05 6:18 ` Vinod Koul
2013-07-07 12:32 ` Russell King - ARM Linux
2013-07-07 13:34 ` Vinod Koul
2013-07-08 2:04 ` Vinod Koul
2013-06-26 8:40 ` Steve Capper
2013-06-26 9:13 ` Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627094650.GC4283@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).