From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/04] ARM: shmobile: Use default ->init_irq() on EMEV2
Date: Mon, 1 Jul 2013 16:32:38 +0900 [thread overview]
Message-ID: <20130701073237.GU14567@verge.net.au> (raw)
In-Reply-To: <20130701060112.21728.37189.sendpatchset@w520>
On Mon, Jul 01, 2013 at 03:01:12PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Remove redundant irqchip_init() callback. The default case
> of NULL will result in invoking irqchip_init() anyway.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> arch/arm/mach-shmobile/setup-emev2.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- 0005/arch/arm/mach-shmobile/setup-emev2.c
> +++ work/arch/arm/mach-shmobile/setup-emev2.c 2013-07-01 13:33:39.000000000 +0900
> @@ -20,7 +20,6 @@
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> -#include <linux/irqchip.h>
> #include <linux/platform_device.h>
> #include <linux/platform_data/gpio-em.h>
> #include <linux/of_platform.h>
> @@ -445,7 +444,6 @@ DT_MACHINE_START(EMEV2_DT, "Generic Emma
> .smp = smp_ops(emev2_smp_ops),
> .init_early = emev2_init_delay,
> .nr_irqs = NR_IRQS_LEGACY,
> - .init_irq = irqchip_init,
> .dt_compat = emev2_boards_compat_dt,
> MACHINE_END
Hi Magnus,
I mistakenly dropped the following patch from Maxime Ripard from
v3.11. I have re-queued it up, for v3.12, in the cleanup branch:
commit 4042de1229ecf083890d8ad5c9327e03b648c1a2
Author: Maxime Ripard <maxime.ripard@free-electrons.com>
Date: Sun May 26 22:05:23 2013 +0900
ARM: shmobile: emev2: Remove init_irq declaration in machine description
Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is
specified") removed the need to explictly setup the init_irq field in
the machine description when using only irqchip_init. Remove that
declaration for shmobile as well.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
diff --git a/arch/arm/mach-shmobile/setup-emev2.c b/arch/arm/mach-shmobile/setup-emev2.c
index 899a86c..66694e0 100644
--- a/arch/arm/mach-shmobile/setup-emev2.c
+++ b/arch/arm/mach-shmobile/setup-emev2.c
@@ -20,7 +20,6 @@
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
-#include <linux/irqchip.h>
#include <linux/platform_device.h>
#include <linux/platform_data/gpio-em.h>
#include <linux/of_platform.h>
@@ -454,7 +453,6 @@ DT_MACHINE_START(EMEV2_DT, "Generic Emma Mobile EV2 (Flattened Device Tree)")
.smp = smp_ops(emev2_smp_ops),
.init_early = emev2_init_delay,
.nr_irqs = NR_IRQS_LEGACY,
- .init_irq = irqchip_init,
.init_machine = emev2_add_standard_devices_dt,
.dt_compat = emev2_boards_compat_dt,
MACHINE_END
next prev parent reply other threads:[~2013-07-01 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 6:01 [PATCH 00/04] ARM: shmobile: Use default ->init_irq() Magnus Damm
2013-07-01 6:01 ` [PATCH 01/04] ARM: shmobile: Use default ->init_irq() on EMEV2 Magnus Damm
2013-07-01 7:32 ` Simon Horman [this message]
2013-07-01 7:48 ` Magnus Damm
2013-07-01 6:01 ` [PATCH 02/04] ARM: shmobile: Use default ->init_irq() on r8a73a4 Magnus Damm
2013-07-01 7:47 ` Simon Horman
2013-07-01 6:01 ` [PATCH 03/04] ARM: shmobile: Use default ->init_irq() on r8a7790 Magnus Damm
2013-07-01 7:52 ` Simon Horman
2013-07-01 6:01 ` [PATCH 04/04] ARM: shmobile: Use default ->init_irq() on sh73a0 Magnus Damm
2013-07-01 7:55 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701073237.GU14567@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox