* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Enable VPU driver
2013-06-28 22:49 [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support Fabio Estevam
@ 2013-06-28 22:49 ` Fabio Estevam
2013-06-29 4:49 ` [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support Matt Sealey
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Fabio Estevam @ 2013-06-28 22:49 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Let VPU driver be selected by default.
VPU driver requires a SRAM pool, so select CONFIG_SRAM as well.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 2353bde..e16384f 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -88,6 +88,7 @@ CONFIG_MTD_UBI=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_SIZE=65536
+CONFIG_SRAM=y
CONFIG_EEPROM_AT24=y
CONFIG_EEPROM_AT25=y
# CONFIG_SCSI_PROC_FS is not set
@@ -169,6 +170,8 @@ CONFIG_SOC_CAMERA=y
CONFIG_SOC_CAMERA_OV2640=y
CONFIG_DRM=y
CONFIG_VIDEO_MX3=y
+CONFIG_V4L_MEM2MEM_DRIVERS=y
+CONFIG_VIDEO_CODA=y
CONFIG_FB=y
CONFIG_LCD_PLATFORM=y
CONFIG_BACKLIGHT_LCD_SUPPORT=y
--
1.8.1.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-06-28 22:49 [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support Fabio Estevam
2013-06-28 22:49 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Enable VPU driver Fabio Estevam
@ 2013-06-29 4:49 ` Matt Sealey
2013-07-01 7:07 ` Philipp Zabel
2013-07-01 12:56 ` Philipp Zabel
2013-07-01 13:05 ` Shawn Guo
3 siblings, 1 reply; 11+ messages in thread
From: Matt Sealey @ 2013-06-29 4:49 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jun 28, 2013 at 5:49 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Enable Video Processing Unit (VPU) support.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Depends on Philipp Zabel's patch:
> [PATCH] ARM: dts: add sram for imx53 and imx6q
>
> Philipp,
>
> I tried using the original mx53 vpu firmware that comes with the FSL BSP, but it
> failed to load:
>
> coda 63ff4000.vpu: firmware get command error
> coda 63ff4000.vpu: HW initialization failed
>
> Any suggestions?
>
> Thanks!
>
> arch/arm/boot/dts/imx53-qsb.dts | 4 ++++
> arch/arm/boot/dts/imx53.dtsi | 10 ++++++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
> index 512a1f6..eedd27e 100644
> --- a/arch/arm/boot/dts/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/imx53-qsb.dts
> @@ -297,6 +297,10 @@
> status = "okay";
> };
>
> +&vpu {
> + status = "okay";
> +};
> +
> &usbh1 {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index 3def46f..f94d4e5 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -1086,6 +1086,16 @@
> crtcs = <&ipu 1>;
> status = "disabled";
> };
> +
> + vpu: vpu at 63ff4000 {
> + compatible = "fsl,imx53-vpu";
> + reg = <0x63ff4000 0x1000>;
> + interrupts = <9>;
> + clocks = <&clks 63>, <&clks 63>;
> + clock-names = "per", "ahb";
> + iram = <&ocram>;
> + status = "disabled";
> + };
> };
>
> ocram: ocram at f8000000 {
Nitpick: what I see here around enabling the VPU driver is;
* A property called iram
* ... that references a node called ocram
* ... which is coincidentally driven by a driver called sram
Could we make up our minds as to what to call it? Something generic
that's potentially not i.MX-specific (since it does change over the
models, and it may not be technically SRAM..) that gets used
everywhere and belies it's purpose rather than naming a particular
technology, or particular IP core documentation if it changes a lot?
--
Matt Sealey <neko@bakuhatsu.net>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-06-29 4:49 ` [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support Matt Sealey
@ 2013-07-01 7:07 ` Philipp Zabel
0 siblings, 0 replies; 11+ messages in thread
From: Philipp Zabel @ 2013-07-01 7:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi Matt,
[Cc: devicetree-discuss at lists.ozlabs.org]
Am Freitag, den 28.06.2013, 23:49 -0500 schrieb Matt Sealey:
> On Fri, Jun 28, 2013 at 5:49 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Enable Video Processing Unit (VPU) support.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > Depends on Philipp Zabel's patch:
> > [PATCH] ARM: dts: add sram for imx53 and imx6q
> >
> > Philipp,
> >
> > I tried using the original mx53 vpu firmware that comes with the FSL BSP, but it
> > failed to load:
> >
> > coda 63ff4000.vpu: firmware get command error
> > coda 63ff4000.vpu: HW initialization failed
> >
> > Any suggestions?
> >
> > Thanks!
> >
> > arch/arm/boot/dts/imx53-qsb.dts | 4 ++++
> > arch/arm/boot/dts/imx53.dtsi | 10 ++++++++++
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
> > index 512a1f6..eedd27e 100644
> > --- a/arch/arm/boot/dts/imx53-qsb.dts
> > +++ b/arch/arm/boot/dts/imx53-qsb.dts
> > @@ -297,6 +297,10 @@
> > status = "okay";
> > };
> >
> > +&vpu {
> > + status = "okay";
> > +};
> > +
> > &usbh1 {
> > status = "okay";
> > };
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index 3def46f..f94d4e5 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -1086,6 +1086,16 @@
> > crtcs = <&ipu 1>;
> > status = "disabled";
> > };
> > +
> > + vpu: vpu at 63ff4000 {
> > + compatible = "fsl,imx53-vpu";
> > + reg = <0x63ff4000 0x1000>;
> > + interrupts = <9>;
> > + clocks = <&clks 63>, <&clks 63>;
> > + clock-names = "per", "ahb";
> > + iram = <&ocram>;
> > + status = "disabled";
> > + };
> > };
> >
> > ocram: ocram at f8000000 {
>
> Nitpick: what I see here around enabling the VPU driver is;
>
> * A property called iram
> * ... that references a node called ocram
> * ... which is coincidentally driven by a driver called sram
>
> Could we make up our minds as to what to call it? Something generic
> that's potentially not i.MX-specific (since it does change over the
> models, and it may not be technically SRAM..) that gets used
> everywhere and belies it's purpose rather than naming a particular
> technology, or particular IP core documentation if it changes a lot?
I'd be in favor of changing
- ocram: ocram at f8000000 {
+ ocram: sram at f8000000 {
but it is very convenient to have the IP vendor's creative name in
there, too, if I have to look it up in the reference manual.
>From point of view of the VPU, the SRAM is a more local memory, in most
implementations connected via a dedicated AXI bus to avoid load on the
main memory bus.
regards
Philipp
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-06-28 22:49 [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support Fabio Estevam
2013-06-28 22:49 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Enable VPU driver Fabio Estevam
2013-06-29 4:49 ` [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support Matt Sealey
@ 2013-07-01 12:56 ` Philipp Zabel
2013-07-01 13:46 ` Fabio Estevam
` (2 more replies)
2013-07-01 13:05 ` Shawn Guo
3 siblings, 3 replies; 11+ messages in thread
From: Philipp Zabel @ 2013-07-01 12:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabio,
Am Freitag, den 28.06.2013, 19:49 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Enable Video Processing Unit (VPU) support.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Depends on Philipp Zabel's patch:
> [PATCH] ARM: dts: add sram for imx53 and imx6q
>
> Philipp,
>
> I tried using the original mx53 vpu firmware that comes with the FSL BSP, but it
> failed to load:
>
> coda 63ff4000.vpu: firmware get command error
> coda 63ff4000.vpu: HW initialization failed
>
> Any suggestions?
>
> Thanks!
/*
* The CODA driver needs the raw firmware without header in memory order.
* This is how I converted vpu_fw_imx53.bin from the Freescale BSP into
* v4l2-coda7541-imx53.bin:
*/
#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
struct fw_header_info {
u_int8_t platform[12];
u_int32_t size;
};
int main(int argc, char *argv[])
{
int fd, i, n, size;
struct fw_header_info header;
u_int32_t *buf;
if (argc < 3) {
fprintf(stderr, "usage: %s <infile> <outfile>\n", argv[0]);
fprintf(stderr, "example: %s vpu_fw_imx53.bin v4l2-coda7541-imx53.bin\n", argv[0]);
return 0;
}
fd = open(argv[1], O_RDONLY);
if (fd < 0) {
fprintf(stderr, "Failed to open source file '%s'.\n", argv[1]);
return EXIT_FAILURE;
}
n = read(fd, &header, sizeof(header));
if (n != sizeof(header)) {
fprintf(stderr, "Failed to read header.\n");
return EXIT_FAILURE;
}
size = header.size * sizeof(u_int16_t);
buf = malloc(size);
if (buf == NULL)
return EXIT_FAILURE;
n = read(fd, buf, size);
if (n != size) {
fprintf(stderr, "Failed to read firmware.\n");
return EXIT_FAILURE;
}
close(fd);
for (i = 0; i < size / 4; i += 2) {
u_int32_t tmp = buf[i + 1] << 16 | buf[i + 1] >> 16;
buf[i + 1] = buf[i] << 16 | buf[i] >> 16;
buf[i] = tmp;
}
fd = open(argv[2], O_RDWR | O_CREAT, 0644);
if (fd < 0)
error("Failed to open target file '%s'.\n", argv[2]);
n = write(fd, buf, size);
if (n != size)
error("Failed to write reordered firmware\n");
close(fd);
return 0;
}
/*
* regards
* Philipp
*/
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-07-01 12:56 ` Philipp Zabel
@ 2013-07-01 13:46 ` Fabio Estevam
2013-07-01 13:59 ` Fabio Estevam
2013-07-01 14:06 ` Philipp Zabel
2013-07-01 22:55 ` Robert Schwebel
2016-02-06 19:54 ` Gary Bisson
2 siblings, 2 replies; 11+ messages in thread
From: Fabio Estevam @ 2013-07-01 13:46 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 1, 2013 at 9:56 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Hi Fabio,
>
> Am Freitag, den 28.06.2013, 19:49 -0300 schrieb Fabio Estevam:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Enable Video Processing Unit (VPU) support.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> Depends on Philipp Zabel's patch:
>> [PATCH] ARM: dts: add sram for imx53 and imx6q
>>
>> Philipp,
>>
>> I tried using the original mx53 vpu firmware that comes with the FSL BSP, but it
>> failed to load:
>>
>> coda 63ff4000.vpu: firmware get command error
>> coda 63ff4000.vpu: HW initialization failed
>>
>> Any suggestions?
>>
>> Thanks!
>
> /*
> * The CODA driver needs the raw firmware without header in memory order.
> * This is how I converted vpu_fw_imx53.bin from the Freescale BSP into
> * v4l2-coda7541-imx53.bin:
> */
Thanks for your C code, Philipp.
Now I get:
coda 63ff4000.vpu: Initialized CODA7541.
coda 63ff4000.vpu: Unsupported firmware version: 13.4.41
coda 63ff4000.vpu: codec registered as /dev/video0
As input file I am using the vpu_fw_imx53.bin from FSL BSP version 11.09.
Where should I get the vpu_fw_imx53.bin file so that I do not get the
unsupported warning?
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-07-01 13:46 ` Fabio Estevam
@ 2013-07-01 13:59 ` Fabio Estevam
2013-07-01 14:06 ` Philipp Zabel
1 sibling, 0 replies; 11+ messages in thread
From: Fabio Estevam @ 2013-07-01 13:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Philipp,
On Mon, Jul 1, 2013 at 10:46 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Thanks for your C code, Philipp.
>
> Now I get:
>
> coda 63ff4000.vpu: Initialized CODA7541.
> coda 63ff4000.vpu: Unsupported firmware version: 13.4.41
> coda 63ff4000.vpu: codec registered as /dev/video0
>
> As input file I am using the vpu_fw_imx53.bin from FSL BSP version 11.09.
>
> Where should I get the vpu_fw_imx53.bin file so that I do not get the
> unsupported warning?
Ok, now I used the mx53 firmware from the latest FSL 4.0.0 BSP and I get:
coda 63ff4000.vpu: Initialized CODA7541.
coda 63ff4000.vpu: Unsupported firmware version: 1.4.50
coda 63ff4000.vpu: codec registered as /dev/video0
and it seems that the version warning appears because your patch:
https://linuxtv.org/patch/19020/ is not applied in the tree linux-next
tree I am using.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-07-01 13:46 ` Fabio Estevam
2013-07-01 13:59 ` Fabio Estevam
@ 2013-07-01 14:06 ` Philipp Zabel
1 sibling, 0 replies; 11+ messages in thread
From: Philipp Zabel @ 2013-07-01 14:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabio,
Am Montag, den 01.07.2013, 10:46 -0300 schrieb Fabio Estevam:
> On Mon, Jul 1, 2013 at 9:56 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > Hi Fabio,
> >
> > Am Freitag, den 28.06.2013, 19:49 -0300 schrieb Fabio Estevam:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Enable Video Processing Unit (VPU) support.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >> ---
> >> Depends on Philipp Zabel's patch:
> >> [PATCH] ARM: dts: add sram for imx53 and imx6q
> >>
> >> Philipp,
> >>
> >> I tried using the original mx53 vpu firmware that comes with the FSL BSP, but it
> >> failed to load:
> >>
> >> coda 63ff4000.vpu: firmware get command error
> >> coda 63ff4000.vpu: HW initialization failed
> >>
> >> Any suggestions?
> >>
> >> Thanks!
> >
> > /*
> > * The CODA driver needs the raw firmware without header in memory order.
> > * This is how I converted vpu_fw_imx53.bin from the Freescale BSP into
> > * v4l2-coda7541-imx53.bin:
> > */
>
> Thanks for your C code, Philipp.
>
> Now I get:
>
> coda 63ff4000.vpu: Initialized CODA7541.
> coda 63ff4000.vpu: Unsupported firmware version: 13.4.41
> coda 63ff4000.vpu: codec registered as /dev/video0
>
> As input file I am using the vpu_fw_imx53.bin from FSL BSP version 11.09.
>
> Where should I get the vpu_fw_imx53.bin file so that I do not get the
> unsupported warning?
The current firmware version is 1.4.50 (yes, 1.4.50 > 13.4.41). It is
contained in the L3.0.35_12.09.01 or L3.0.35_4.0.0 (20130424) BSP
releases.
regards
Philipp
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-07-01 12:56 ` Philipp Zabel
2013-07-01 13:46 ` Fabio Estevam
@ 2013-07-01 22:55 ` Robert Schwebel
2016-02-06 19:54 ` Gary Bisson
2 siblings, 0 replies; 11+ messages in thread
From: Robert Schwebel @ 2013-07-01 22:55 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 01, 2013 at 02:56:36PM +0200, Philipp Zabel wrote:
> /*
> * The CODA driver needs the raw firmware without header in memory order.
> * This is how I converted vpu_fw_imx53.bin from the Freescale BSP into
> * v4l2-coda7541-imx53.bin:
> */
That code sniplet should get a GPL license header.
rsc
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-07-01 12:56 ` Philipp Zabel
2013-07-01 13:46 ` Fabio Estevam
2013-07-01 22:55 ` Robert Schwebel
@ 2016-02-06 19:54 ` Gary Bisson
2 siblings, 0 replies; 11+ messages in thread
From: Gary Bisson @ 2016-02-06 19:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Philipp,
On Mon, Jul 01, 2013 at 02:56:36PM +0200, Philipp Zabel wrote:
> Hi Fabio,
>
> Am Freitag, den 28.06.2013, 19:49 -0300 schrieb Fabio Estevam:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Enable Video Processing Unit (VPU) support.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > Depends on Philipp Zabel's patch:
> > [PATCH] ARM: dts: add sram for imx53 and imx6q
> >
> > Philipp,
> >
> > I tried using the original mx53 vpu firmware that comes with the FSL BSP, but it
> > failed to load:
> >
> > coda 63ff4000.vpu: firmware get command error
> > coda 63ff4000.vpu: HW initialization failed
> >
> > Any suggestions?
> >
> > Thanks!
>
> /*
> * The CODA driver needs the raw firmware without header in memory order.
> * This is how I converted vpu_fw_imx53.bin from the Freescale BSP into
> * v4l2-coda7541-imx53.bin:
> */
Sorry to revive an old thread but I was wondering if that firmware
conversion tool is available somewhere on a git repo?
Regards,
Gary
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support
2013-06-28 22:49 [PATCH 1/2] ARM: dts: mx53qsb: Enable VPU support Fabio Estevam
` (2 preceding siblings ...)
2013-07-01 12:56 ` Philipp Zabel
@ 2013-07-01 13:05 ` Shawn Guo
3 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2013-07-01 13:05 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jun 28, 2013 at 07:49:18PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Enable Video Processing Unit (VPU) support.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Both applied, thanks.
Shawn
^ permalink raw reply [flat|nested] 11+ messages in thread