* On common struct clk in clock framework. @ 2013-07-03 13:35 mind entropy 2013-07-03 18:07 ` Tomasz Figa 0 siblings, 1 reply; 7+ messages in thread From: mind entropy @ 2013-07-03 13:35 UTC (permalink / raw) To: linux-arm-kernel Hi, I am reading through mini2440 code and trying to understand clocking code. I am getting confused as to whether it uses the common clocking framework. In https://github.com/torvalds/linux/blob/master/arch/arm/plat-samsung/include/plat/clock.h#L42 they define a struct clk. Even in OMAP (http://processors.wiki.ti.com/index.php/Clock_Framework_User_Guide#Software_Implementation) they have a separate struct clk definition. In the common clocking framework shouldn't they be using the common struct clk rather than have their own versions of struct clk? Thanks in advance. ^ permalink raw reply [flat|nested] 7+ messages in thread
* On common struct clk in clock framework. 2013-07-03 13:35 On common struct clk in clock framework mind entropy @ 2013-07-03 18:07 ` Tomasz Figa 2013-07-04 4:51 ` mind entropy 0 siblings, 1 reply; 7+ messages in thread From: Tomasz Figa @ 2013-07-03 18:07 UTC (permalink / raw) To: linux-arm-kernel Hi, On Wednesday 03 of July 2013 19:05:03 mind entropy wrote: > Hi, > > I am reading through mini2440 code and trying to understand > clocking code. I am getting confused as to whether it uses the common > clocking framework. In > https://github.com/torvalds/linux/blob/master/arch/arm/plat-samsung/incl > ude/plat/clock.h#L42 they define a struct clk. Even in OMAP > (http://processors.wiki.ti.com/index.php/Clock_Framework_User_Guide#Soft > ware_Implementation) they have a separate struct clk definition. In the > common clocking framework shouldn't they be using the common struct clk > rather than have their own versions of struct clk? The examples you pointed are not using Common Clock Framework. See Documentation/clk.txt and drivers/clk/ for more information about CCF. As for s3c24xx, CCF driver for the whole platform is already merged for Linux 3.11. Best regards, Tomasz ^ permalink raw reply [flat|nested] 7+ messages in thread
* On common struct clk in clock framework. 2013-07-03 18:07 ` Tomasz Figa @ 2013-07-04 4:51 ` mind entropy 2013-07-04 5:07 ` Mike Turquette 2013-07-04 10:32 ` Tomasz Figa 0 siblings, 2 replies; 7+ messages in thread From: mind entropy @ 2013-07-04 4:51 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > The examples you pointed are not using Common Clock Framework. See > Documentation/clk.txt and drivers/clk/ for more information about CCF. > > As for s3c24xx, CCF driver for the whole platform is already merged for > Linux 3.11. > > Best regards, > Tomasz > Thanks TomasZ. I have gone through the docs and was quite confused. I will have a look at the merge. ^ permalink raw reply [flat|nested] 7+ messages in thread
* On common struct clk in clock framework. 2013-07-04 4:51 ` mind entropy @ 2013-07-04 5:07 ` Mike Turquette 2013-07-04 10:32 ` Tomasz Figa 1 sibling, 0 replies; 7+ messages in thread From: Mike Turquette @ 2013-07-04 5:07 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 3, 2013 at 9:51 PM, mind entropy <mindentropy@gmail.com> wrote: > On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: >> >> The examples you pointed are not using Common Clock Framework. See >> Documentation/clk.txt and drivers/clk/ for more information about CCF. >> >> As for s3c24xx, CCF driver for the whole platform is already merged for >> Linux 3.11. >> >> Best regards, >> Tomasz >> > > Thanks TomasZ. I have gone through the docs and was quite confused. I > will have a look at the merge. Any clock implementation that defines its own struct clk is a legacy clock framework and is not using the common clock infrastructure. Another hint is if you see a clock driver that includes linux/clk-provider.h, this implies a clock driver that is using the common clock framework. Regards, Mike > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* On common struct clk in clock framework. 2013-07-04 4:51 ` mind entropy 2013-07-04 5:07 ` Mike Turquette @ 2013-07-04 10:32 ` Tomasz Figa 2013-07-04 10:58 ` Heiko Stübner 1 sibling, 1 reply; 7+ messages in thread From: Tomasz Figa @ 2013-07-04 10:32 UTC (permalink / raw) To: linux-arm-kernel On Thursday 04 of July 2013 10:21:27 mind entropy wrote: > On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > The examples you pointed are not using Common Clock Framework. See > > Documentation/clk.txt and drivers/clk/ for more information about CCF. > > > > As for s3c24xx, CCF driver for the whole platform is already merged for > > Linux 3.11. > > > > Best regards, > > Tomasz > > Thanks TomasZ. I have gone through the docs and was quite confused. I > will have a look at the merge. Oops. It seems like s3c24xx clk driver is not merged yet. I don't know why I thought it is. Heiko (on CC) has been working on it and I remember seeing some patches from him. Sorry for misinformation. Best regards, Tomasz > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 7+ messages in thread
* On common struct clk in clock framework. 2013-07-04 10:32 ` Tomasz Figa @ 2013-07-04 10:58 ` Heiko Stübner 2013-07-04 11:07 ` Heiko Stübner 0 siblings, 1 reply; 7+ messages in thread From: Heiko Stübner @ 2013-07-04 10:58 UTC (permalink / raw) To: linux-arm-kernel Hi, Am Donnerstag, 4. Juli 2013, 12:32:26 schrieb Tomasz Figa: > On Thursday 04 of July 2013 10:21:27 mind entropy wrote: > > On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> > > wrote: > > > The examples you pointed are not using Common Clock Framework. See > > > Documentation/clk.txt and drivers/clk/ for more information about CCF. > > > > > > As for s3c24xx, CCF driver for the whole platform is already merged for > > > Linux 3.11. > > > > > > Best regards, > > > Tomasz > > > > Thanks TomasZ. I have gone through the docs and was quite confused. I > > will have a look at the merge. > > Oops. It seems like s3c24xx clk driver is not merged yet. I don't know why > I thought it is. Heiko (on CC) has been working on it and I remember seeing > some patches from him. Sorry for misinformation. the ccf conversion should be ready, but at the time I submitted them, the pwm rework [that got rid of the pwm-internal clocks] was still missing. At some point in the threads I lost track of its state, did the pwm rework make it into 3.11 after all, or is it an early 3.12 change? Heiko ^ permalink raw reply [flat|nested] 7+ messages in thread
* On common struct clk in clock framework. 2013-07-04 10:58 ` Heiko Stübner @ 2013-07-04 11:07 ` Heiko Stübner 0 siblings, 0 replies; 7+ messages in thread From: Heiko Stübner @ 2013-07-04 11:07 UTC (permalink / raw) To: linux-arm-kernel Am Donnerstag, 4. Juli 2013, 12:58:48 schrieb Heiko St?bner: > Hi, > > Am Donnerstag, 4. Juli 2013, 12:32:26 schrieb Tomasz Figa: > > On Thursday 04 of July 2013 10:21:27 mind entropy wrote: > > > On Wed, Jul 3, 2013 at 11:37 PM, Tomasz Figa <tomasz.figa@gmail.com> > > > > wrote: > > > > The examples you pointed are not using Common Clock Framework. See > > > > Documentation/clk.txt and drivers/clk/ for more information about > > > > CCF. > > > > > > > > As for s3c24xx, CCF driver for the whole platform is already merged > > > > for Linux 3.11. > > > > > > > > Best regards, > > > > Tomasz > > > > > > Thanks TomasZ. I have gone through the docs and was quite confused. I > > > will have a look at the merge. > > > > Oops. It seems like s3c24xx clk driver is not merged yet. I don't know > > why I thought it is. Heiko (on CC) has been working on it and I remember > > seeing some patches from him. Sorry for misinformation. > > the ccf conversion should be ready, but at the time I submitted them, the > pwm rework [that got rid of the pwm-internal clocks] was still missing. > > At some point in the threads I lost track of its state, did the pwm rework > make it into 3.11 after all, or is it an early 3.12 change? of course I forgot the most important thing :-) There is a big red line between the clocks starting with the s3c2443 and the other s3c24xx before it - they have nearly nothing in common. The ccf driver I created [0] therefore only provides the clocks for s3c2443, s3c2416 and s3c2450, which are very similar. Heiko [0] http://patches.sntech.de/projects/linux-kernel/01_mailinglist/s3c2416- common-clk/ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-07-04 11:07 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-07-03 13:35 On common struct clk in clock framework mind entropy 2013-07-03 18:07 ` Tomasz Figa 2013-07-04 4:51 ` mind entropy 2013-07-04 5:07 ` Mike Turquette 2013-07-04 10:32 ` Tomasz Figa 2013-07-04 10:58 ` Heiko Stübner 2013-07-04 11:07 ` Heiko Stübner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).