* [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference
@ 2013-07-09 4:26 Magnus Damm
2013-07-09 11:45 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Magnus Damm @ 2013-07-09 4:26 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Add support for the SMSC ethernet controller found
on the KZM9D board to the KZM9D DT Reference code.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Built on top of renesas-next-20130704v2 and
[PATCH] ARM: shmobile: KZM9D DT reference implementation
arch/arm/boot/dts/emev2-kzm9d-reference.dts | 31 +++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
--- 0002/arch/arm/boot/dts/emev2-kzm9d-reference.dts
+++ work/arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 13:06:47.000000000 +0900
@@ -23,4 +23,35 @@
chosen {
bootargs = "console=ttyS1,115200n81 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize=4096,wsize=4096";
};
+
+ reg_1p8v: regulator at 0 {
+ compatible = "regulator-fixed";
+ regulator-name = "fixed-1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ reg_3p3v: regulator at 1 {
+ compatible = "regulator-fixed";
+ regulator-name = "fixed-3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ lan9220 at 20000000 {
+ compatible = "smsc,lan9220", "smsc,lan9115";
+ reg = <0x20000000 0x10000>;
+ phy-mode = "mii";
+ interrupt-parent = <&gpio0>;
+ interrupts = <1 1>; /* active high */
+ reg-io-width = <4>;
+ smsc,irq-active-high;
+ smsc,irq-push-pull;
+ vddvario-supply = <®_1p8v>;
+ vdd33a-supply = <®_3p3v>;
+ };
};
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference
2013-07-09 4:26 [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference Magnus Damm
@ 2013-07-09 11:45 ` Sergei Shtylyov
2013-07-09 13:03 ` Magnus Damm
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2013-07-09 11:45 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 09-07-2013 8:26, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> Add support for the SMSC ethernet controller found
> on the KZM9D board to the KZM9D DT Reference code.
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> Built on top of renesas-next-20130704v2 and
> [PATCH] ARM: shmobile: KZM9D DT reference implementation
> arch/arm/boot/dts/emev2-kzm9d-reference.dts | 31 +++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> --- 0002/arch/arm/boot/dts/emev2-kzm9d-reference.dts
> +++ work/arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09 13:06:47.000000000 +0900
> @@ -23,4 +23,35 @@
[...]
> + lan9220 at 20000000 {
Shouldn't all the Ethernet nodes be called "ethernet"?
> + compatible = "smsc,lan9220", "smsc,lan9115";
> + reg = <0x20000000 0x10000>;
> + phy-mode = "mii";
> + interrupt-parent = <&gpio0>;
> + interrupts = <1 1>; /* active high */
> + reg-io-width = <4>;
> + smsc,irq-active-high;
> + smsc,irq-push-pull;
> + vddvario-supply = <®_1p8v>;
> + vdd33a-supply = <®_3p3v>;
> + };
> };
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference
2013-07-09 11:45 ` Sergei Shtylyov
@ 2013-07-09 13:03 ` Magnus Damm
2013-07-09 13:09 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Magnus Damm @ 2013-07-09 13:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Tue, Jul 9, 2013 at 8:45 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
>
> On 09-07-2013 8:26, Magnus Damm wrote:
>
>> From: Magnus Damm <damm@opensource.se>
>
>
>> Add support for the SMSC ethernet controller found
>> on the KZM9D board to the KZM9D DT Reference code.
>
>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>> ---
>
>
>> Built on top of renesas-next-20130704v2 and
>> [PATCH] ARM: shmobile: KZM9D DT reference implementation
>
>
>> arch/arm/boot/dts/emev2-kzm9d-reference.dts | 31
>> +++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>
>
>> --- 0002/arch/arm/boot/dts/emev2-kzm9d-reference.dts
>> +++ work/arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09
>> 13:06:47.000000000 +0900
>> @@ -23,4 +23,35 @@
>
> [...]
>>
>> + lan9220 at 20000000 {
>
>
> Shouldn't all the Ethernet nodes be called "ethernet"?
Good question. Grepping in arch/arm/boot/dts shows various ways to
name the Ethernet nodes. Exactly what is correct or not I can't really
say.
Thanks for your feedback.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference
2013-07-09 13:03 ` Magnus Damm
@ 2013-07-09 13:09 ` Sergei Shtylyov
2013-07-10 1:03 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2013-07-09 13:09 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 09-07-2013 17:03, Magnus Damm wrote:
>>> From: Magnus Damm <damm@opensource.se>
>>> Add support for the SMSC ethernet controller found
>>> on the KZM9D board to the KZM9D DT Reference code.
>>> Signed-off-by: Magnus Damm <damm@opensource.se>
>>> ---
>>> Built on top of renesas-next-20130704v2 and
>>> [PATCH] ARM: shmobile: KZM9D DT reference implementation
>>> arch/arm/boot/dts/emev2-kzm9d-reference.dts | 31
>>> +++++++++++++++++++++++++++
>>> 1 file changed, 31 insertions(+)
>>> --- 0002/arch/arm/boot/dts/emev2-kzm9d-reference.dts
>>> +++ work/arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09
>>> 13:06:47.000000000 +0900
>>> @@ -23,4 +23,35 @@
>> [...]
>>> + lan9220 at 20000000 {
>> Shouldn't all the Ethernet nodes be called "ethernet"?
> Good question. Grepping in arch/arm/boot/dts shows various ways to
> name the Ethernet nodes. Exactly what is correct or not I can't really
> say.
See "Node Names" section of [1].
[1] http://www.devicetree.org/Device_Tree_Usage
> Thanks for your feedback.
> Cheers,
> / magnus
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference
2013-07-09 13:09 ` Sergei Shtylyov
@ 2013-07-10 1:03 ` Simon Horman
2013-08-04 18:51 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2013-07-10 1:03 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 09, 2013 at 05:09:52PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09-07-2013 17:03, Magnus Damm wrote:
>
> >>>From: Magnus Damm <damm@opensource.se>
>
> >>>Add support for the SMSC ethernet controller found
> >>>on the KZM9D board to the KZM9D DT Reference code.
>
> >>>Signed-off-by: Magnus Damm <damm@opensource.se>
> >>>---
>
> >>> Built on top of renesas-next-20130704v2 and
> >>> [PATCH] ARM: shmobile: KZM9D DT reference implementation
>
> >>> arch/arm/boot/dts/emev2-kzm9d-reference.dts | 31
> >>>+++++++++++++++++++++++++++
> >>> 1 file changed, 31 insertions(+)
>
> >>>--- 0002/arch/arm/boot/dts/emev2-kzm9d-reference.dts
> >>>+++ work/arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09
> >>>13:06:47.000000000 +0900
> >>>@@ -23,4 +23,35 @@
>
> >>[...]
>
> >>>+ lan9220 at 20000000 {
>
> >> Shouldn't all the Ethernet nodes be called "ethernet"?
>
> >Good question. Grepping in arch/arm/boot/dts shows various ways to
> >name the Ethernet nodes. Exactly what is correct or not I can't really
> >say.
>
> See "Node Names" section of [1].
>
> [1] http://www.devicetree.org/Device_Tree_Usage
I will queue up this patch for v3.12 in the dt branch and
it should appear in renesas-next-20130710.
If there is a desire to consistently name nodes as "ethernet" for shmobile
then I would appreciate a cleanup patches to fix all the relevant dts and
dtsi files. One SoC or board per patch.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference
2013-07-10 1:03 ` Simon Horman
@ 2013-08-04 18:51 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2013-08-04 18:51 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 10, 2013 at 10:03:17AM +0900, Simon Horman wrote:
> On Tue, Jul 09, 2013 at 05:09:52PM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 09-07-2013 17:03, Magnus Damm wrote:
> >
> > >>>From: Magnus Damm <damm@opensource.se>
> >
> > >>>Add support for the SMSC ethernet controller found
> > >>>on the KZM9D board to the KZM9D DT Reference code.
> >
> > >>>Signed-off-by: Magnus Damm <damm@opensource.se>
> > >>>---
> >
> > >>> Built on top of renesas-next-20130704v2 and
> > >>> [PATCH] ARM: shmobile: KZM9D DT reference implementation
> >
> > >>> arch/arm/boot/dts/emev2-kzm9d-reference.dts | 31
> > >>>+++++++++++++++++++++++++++
> > >>> 1 file changed, 31 insertions(+)
> >
> > >>>--- 0002/arch/arm/boot/dts/emev2-kzm9d-reference.dts
> > >>>+++ work/arch/arm/boot/dts/emev2-kzm9d-reference.dts 2013-07-09
> > >>>13:06:47.000000000 +0900
> > >>>@@ -23,4 +23,35 @@
> >
> > >>[...]
> >
> > >>>+ lan9220 at 20000000 {
> >
> > >> Shouldn't all the Ethernet nodes be called "ethernet"?
> >
> > >Good question. Grepping in arch/arm/boot/dts shows various ways to
> > >name the Ethernet nodes. Exactly what is correct or not I can't really
> > >say.
> >
> > See "Node Names" section of [1].
> >
> > [1] http://www.devicetree.org/Device_Tree_Usage
>
> I will queue up this patch for v3.12 in the dt branch and
> it should appear in renesas-next-20130710.
>
> If there is a desire to consistently name nodes as "ethernet" for shmobile
> then I would appreciate a cleanup patches to fix all the relevant dts and
> dtsi files. One SoC or board per patch.
Yes, they should be named ethernet. Rename when you have a chance and/or are
touching the files for other nearby changes.
Also, the 9220 chips are usually located on a general-purpose external parallel
bus, but they're not modelled that way here. You might want to add proper
bindings for future devices on said busses (handling chipselects, etc, as
needed).
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-04 18:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-09 4:26 [PATCH] ARM: shmobile: Add SMSC ethernet chip to KZM9D DT reference Magnus Damm
2013-07-09 11:45 ` Sergei Shtylyov
2013-07-09 13:03 ` Magnus Damm
2013-07-09 13:09 ` Sergei Shtylyov
2013-07-10 1:03 ` Simon Horman
2013-08-04 18:51 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).