From: markus@trippelsdorf.de (Markus Trippelsdorf)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format
Date: Wed, 10 Jul 2013 20:28:15 +0200 [thread overview]
Message-ID: <20130710182815.GA362@x4> (raw)
In-Reply-To: <20130710093642.GC14873@pd.tnic>
On 2013.07.10 at 11:36 +0200, Borislav Petkov wrote:
> On Wed, Jul 10, 2013 at 10:12:46AM +0200, Geert Uytterhoeven wrote:
> > >> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> > >> index a0ab6d7..c9bfbb0 100644
> > >> --- a/scripts/Makefile.lib
> > >> +++ b/scripts/Makefile.lib
> > >> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \
> > >>
> > >> quiet_cmd_lz4 = LZ4 $@
> > >> cmd_lz4 = (cat $(filter-out FORCE,$^) | \
> > >> - lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
> > >> + lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
> > >
> > > You probably want to check for the presence of lz4c on the system and
> > > bail with an informative message if absent.
> >
> > Yep, x86_64-randconfig
> > (http://kisskb.ellerman.id.au/kisskb/buildresult/9110794/):
> >
> > LZ4 arch/x86/boot/compressed/vmlinux.bin.lz4
> > /bin/sh: lz4c: command not found
>
> Sure, it had to be 2 months and to hit upstream for there still to be no
> fix. Geez...
Well, there's also no hand-holding when lzop is missing for LZO.
And the error message is clear enough. No?
BTW speaking of introductory-level patches, what about the following
one:
Now that lz4 kernel compression is available, add *.lz4 to .gitignore
diff --git a/.gitignore b/.gitignore
index 3b8b9b3..7e9932e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -29,6 +29,7 @@ modules.builtin
*.bz2
*.lzma
*.xz
+*.lz4
*.lzo
*.patch
*.gcno
--
Markus
next prev parent reply other threads:[~2013-07-10 18:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 8:42 [PATCH -next 1/2] arm: Remove enforced Os flag for LZ4 decompressor Kyungsik Lee
2013-05-06 8:42 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Kyungsik Lee
2013-05-06 9:51 ` Borislav Petkov
2013-07-10 8:12 ` Geert Uytterhoeven
2013-07-10 9:36 ` Borislav Petkov
2013-07-10 18:28 ` Markus Trippelsdorf [this message]
2013-07-10 20:01 ` Borislav Petkov
2013-07-11 4:34 ` Kyungsik Lee
2013-07-11 9:46 ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf
2013-07-12 7:56 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Ingo Molnar
2013-07-12 8:01 ` Borislav Petkov
2013-07-12 10:13 ` Ingo Molnar
2013-07-12 10:23 ` Borislav Petkov
2013-07-12 11:18 ` Andrew Morton
2013-07-12 12:06 ` Ingo Molnar
2013-07-12 12:13 ` Borislav Petkov
2013-07-12 12:34 ` Florian Fainelli
2013-07-12 12:46 ` Borislav Petkov
2013-07-15 22:03 ` Andrew Morton
2013-07-15 22:08 ` H. Peter Anvin
2013-07-16 7:47 ` Andrew Morton
2013-07-16 7:56 ` Andrew Morton
2013-07-16 8:08 ` Yann E. MORIN
2013-07-16 8:27 ` Andrew Morton
2013-07-16 9:05 ` Borislav Petkov
2013-07-16 9:12 ` Yann E. MORIN
2013-07-16 9:22 ` Borislav Petkov
2013-07-16 9:32 ` Yann E. MORIN
2013-07-16 9:38 ` Borislav Petkov
2013-07-16 9:45 ` Yann E. MORIN
2013-07-16 9:59 ` Borislav Petkov
2013-07-16 10:04 ` Florian Fainelli
2013-07-16 18:04 ` Sam Ravnborg
2013-07-17 21:16 ` Sam Ravnborg
2013-07-17 21:44 ` Borislav Petkov
2013-07-17 22:30 ` Yann E. MORIN
2013-07-17 23:22 ` H. Peter Anvin
2013-07-18 8:02 ` Geert Uytterhoeven
2013-07-18 7:22 ` Geert Uytterhoeven
2013-07-18 7:34 ` Andrew Morton
2013-07-18 7:47 ` Yann E. MORIN
2013-07-18 7:52 ` Andrew Morton
2013-07-18 20:47 ` Sam Ravnborg
2013-07-16 9:13 ` Florian Fainelli
2013-07-16 9:25 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710182815.GA362@x4 \
--to=markus@trippelsdorf.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).