From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: twl-common: Remove code for twl6030 and twl6040 setup for legacy boot
Date: Thu, 11 Jul 2013 09:59:16 -0500 [thread overview]
Message-ID: <20130711145916.GA6138@kahuna> (raw)
In-Reply-To: <1373552638-13930-1-git-send-email-peter.ujfalusi@ti.com>
On 16:23-20130711, Peter Ujfalusi wrote:
> OMAP4 no longer boots in legacy mode so the code here is no longer used.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/arm/mach-omap2/twl-common.c | 332 ++-------------------------------------
> arch/arm/mach-omap2/twl-common.h | 8 -
> 2 files changed, 12 insertions(+), 328 deletions(-)
Could we modify the Makefile and build twl-common.o only for
CONFIG_ARCH_OMAP3?
We could get rid of all the #ifdef from the code that way. OMAP3 is the
only platform that still depends on this - Further, with this change,
commit 34a38440689b06a515104d668494e0ff8a4e1537
(regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators)
will need a relook as well. currently part of the discussion with Mark
in [1]
[1] http://marc.info/?t=137185016300003&r=1&w=2
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-07-11 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 14:23 [PATCH] ARM: OMAP2+: twl-common: Remove code for twl6030 and twl6040 setup for legacy boot Peter Ujfalusi
2013-07-11 14:59 ` Nishanth Menon [this message]
2013-07-11 15:45 ` Peter Ujfalusi
2013-07-11 16:35 ` Nishanth Menon
2013-07-12 8:59 ` Peter Ujfalusi
2013-07-12 9:27 ` Peter Ujfalusi
2013-07-12 7:26 ` Tony Lindgren
2013-07-12 8:13 ` Peter Ujfalusi
2013-07-12 8:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711145916.GA6138@kahuna \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).