linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mingo@kernel.org (Ingo Molnar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format
Date: Fri, 12 Jul 2013 09:56:02 +0200	[thread overview]
Message-ID: <20130712075602.GA4002@gmail.com> (raw)
In-Reply-To: <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com>


* Kyungsik Lee <kyungsik.lee@lge.com> wrote:

> LZ4 has been updated with LZ4 Streaming Format specification(v1.3).
> lz4demo is replaced by lz4c. lz4c supports both the new streaming and
> legacy format with -l option.
> 
> This patch makes use of lz4c to support legacy format which is
> used for LZ4 De/compression in the linux kernel.
> 
> Link: https://code.google.com/p/lz4/source/checkout
> Signed-off-by: Kyungsik Lee <kyungsik.lee@lge.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Russell King <rmk@arm.linux.org.uk>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Florian Fainelli <florian@openwrt.org>
> Cc: Yann Collet <yann.collet.73@gmail.com>
> Cc: Chanho Min <chanho.min@lge.com>
> ---
>  scripts/Makefile.lib | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index a0ab6d7..c9bfbb0 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -313,7 +313,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \
>  
>  quiet_cmd_lz4 = LZ4     $@
>  cmd_lz4 = (cat $(filter-out FORCE,$^) | \
> -	lz4demo -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
> +	lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
>  	(rm -f $@ ; false)

None of the major distros I tried has the lz4 or lz4c binary available, 
and this breaks randconfig builds:

  /bin/sh: lz4c: command not found

If:

 CONFIG_HAVE_KERNEL_LZ4=y
 CONFIG_KERNEL_LZ4=y
 CONFIG_RD_LZ4=y
 CONFIG_LZ4_DECOMPRESS=y
 CONFIG_DECOMPRESS_LZ4=y

If a utility is not widely available yet and if the utility is not in the 
kernel proper, could you please at least make sure that randconfig does 
not stumble over non-buildable kernels?

Thanks,

	Ingo

  parent reply	other threads:[~2013-07-12  7:56 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  8:42 [PATCH -next 1/2] arm: Remove enforced Os flag for LZ4 decompressor Kyungsik Lee
2013-05-06  8:42 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Kyungsik Lee
2013-05-06  9:51   ` Borislav Petkov
2013-07-10  8:12     ` Geert Uytterhoeven
2013-07-10  9:36       ` Borislav Petkov
2013-07-10 18:28         ` Markus Trippelsdorf
2013-07-10 20:01           ` Borislav Petkov
2013-07-11  4:34           ` Kyungsik Lee
2013-07-11  9:46             ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf
2013-07-12  7:56   ` Ingo Molnar [this message]
2013-07-12  8:01     ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Borislav Petkov
2013-07-12 10:13       ` Ingo Molnar
2013-07-12 10:23         ` Borislav Petkov
2013-07-12 11:18           ` Andrew Morton
2013-07-12 12:06             ` Ingo Molnar
2013-07-12 12:13             ` Borislav Petkov
2013-07-12 12:34               ` Florian Fainelli
2013-07-12 12:46                 ` Borislav Petkov
2013-07-15 22:03     ` Andrew Morton
2013-07-15 22:08       ` H. Peter Anvin
2013-07-16  7:47         ` Andrew Morton
2013-07-16  7:56           ` Andrew Morton
2013-07-16  8:08             ` Yann E. MORIN
2013-07-16  8:27               ` Andrew Morton
2013-07-16  9:05                 ` Borislav Petkov
2013-07-16  9:12                   ` Yann E. MORIN
2013-07-16  9:22                     ` Borislav Petkov
2013-07-16  9:32                       ` Yann E. MORIN
2013-07-16  9:38                         ` Borislav Petkov
2013-07-16  9:45                           ` Yann E. MORIN
2013-07-16  9:59                             ` Borislav Petkov
2013-07-16 10:04                               ` Florian Fainelli
2013-07-16 18:04               ` Sam Ravnborg
2013-07-17 21:16                 ` Sam Ravnborg
2013-07-17 21:44                   ` Borislav Petkov
2013-07-17 22:30                   ` Yann E. MORIN
2013-07-17 23:22                     ` H. Peter Anvin
2013-07-18  8:02                       ` Geert Uytterhoeven
2013-07-18  7:22                     ` Geert Uytterhoeven
2013-07-18  7:34                       ` Andrew Morton
2013-07-18  7:47                         ` Yann E. MORIN
2013-07-18  7:52                           ` Andrew Morton
2013-07-18 20:47                     ` Sam Ravnborg
2013-07-16  9:13             ` Florian Fainelli
2013-07-16  9:25               ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130712075602.GA4002@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).