linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format
Date: Thu, 18 Jul 2013 00:52:03 -0700	[thread overview]
Message-ID: <20130718005203.9e9dc1d1.akpm@linux-foundation.org> (raw)
In-Reply-To: <201307180947.02456.yann.morin.1998@free.fr>

On Thu, 18 Jul 2013 09:47:02 +0200 "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > 
> > I prefer the "option exec" approach, actually.  That way the shell-outs
> > are colocated with the code which uses
> 
> Indeed, but in this case, all the checks will be spread-out in the Kconfig
> files, and not easily locatable. Having all in a single script will also
> more easily raise eyebrows when that script appears in a diffstat. Noticing
> the 'exec' option risks being a bit less easy.

Eh, there are a million ways to screw up the kernel.

> But, that's not my call to decide. ;-)
> 
> > them and they will only be executed
> > if you've actually selected that subsystem for building (I think?).
> 
> If I understand the code correctly (which is still to be proven), the
> exec option is run at parse-time, once.

Yes, but not every Kconfig file in the tree gets parsed every time. 
For example, if arch/arm/Kconfig uses "option exec=some-slow-thing",
x86 users won't execute some-slow-thing.  This is good.

  reply	other threads:[~2013-07-18  7:52 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  8:42 [PATCH -next 1/2] arm: Remove enforced Os flag for LZ4 decompressor Kyungsik Lee
2013-05-06  8:42 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Kyungsik Lee
2013-05-06  9:51   ` Borislav Petkov
2013-07-10  8:12     ` Geert Uytterhoeven
2013-07-10  9:36       ` Borislav Petkov
2013-07-10 18:28         ` Markus Trippelsdorf
2013-07-10 20:01           ` Borislav Petkov
2013-07-11  4:34           ` Kyungsik Lee
2013-07-11  9:46             ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf
2013-07-12  7:56   ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Ingo Molnar
2013-07-12  8:01     ` Borislav Petkov
2013-07-12 10:13       ` Ingo Molnar
2013-07-12 10:23         ` Borislav Petkov
2013-07-12 11:18           ` Andrew Morton
2013-07-12 12:06             ` Ingo Molnar
2013-07-12 12:13             ` Borislav Petkov
2013-07-12 12:34               ` Florian Fainelli
2013-07-12 12:46                 ` Borislav Petkov
2013-07-15 22:03     ` Andrew Morton
2013-07-15 22:08       ` H. Peter Anvin
2013-07-16  7:47         ` Andrew Morton
2013-07-16  7:56           ` Andrew Morton
2013-07-16  8:08             ` Yann E. MORIN
2013-07-16  8:27               ` Andrew Morton
2013-07-16  9:05                 ` Borislav Petkov
2013-07-16  9:12                   ` Yann E. MORIN
2013-07-16  9:22                     ` Borislav Petkov
2013-07-16  9:32                       ` Yann E. MORIN
2013-07-16  9:38                         ` Borislav Petkov
2013-07-16  9:45                           ` Yann E. MORIN
2013-07-16  9:59                             ` Borislav Petkov
2013-07-16 10:04                               ` Florian Fainelli
2013-07-16 18:04               ` Sam Ravnborg
2013-07-17 21:16                 ` Sam Ravnborg
2013-07-17 21:44                   ` Borislav Petkov
2013-07-17 22:30                   ` Yann E. MORIN
2013-07-17 23:22                     ` H. Peter Anvin
2013-07-18  8:02                       ` Geert Uytterhoeven
2013-07-18  7:22                     ` Geert Uytterhoeven
2013-07-18  7:34                       ` Andrew Morton
2013-07-18  7:47                         ` Yann E. MORIN
2013-07-18  7:52                           ` Andrew Morton [this message]
2013-07-18 20:47                     ` Sam Ravnborg
2013-07-16  9:13             ` Florian Fainelli
2013-07-16  9:25               ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130718005203.9e9dc1d1.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).