From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: alignment handler instruction endian-ness
Date: Fri, 19 Jul 2013 12:09:47 +0100 [thread overview]
Message-ID: <20130719110947.GD24642@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <51E91BE5.8070809@codethink.co.uk>
On Fri, Jul 19, 2013 at 11:58:45AM +0100, Ben Dooks wrote:
> I ran in to an issue with the alignment handler when running BE8 where
> it loads instructions and fails to swap.
>
> Is there a better way of swapping instructions for ARM when loading
> from arbitrary places? Have I missed any other places this could happen?
Maybe we need a macro which deals with this automatically?
arm_instr_to_cpu(x)
thumb_instr_to_cpu(x)
These should probably make use of the swab*() macros when an endian swap
is needed.
> The following patch is my first attempt at solving the problem for the
> alignment handler:
I'd suggest checking this with sparse too - you have some type errors here.
next prev parent reply other threads:[~2013-07-19 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 10:58 alignment handler instruction endian-ness Ben Dooks
2013-07-19 11:09 ` Russell King - ARM Linux [this message]
2013-07-19 11:26 ` Ben Dooks
2013-07-19 12:15 ` Ben Dooks
2013-07-19 12:32 ` Russell King - ARM Linux
2013-07-19 13:19 ` Ben Dooks
2013-07-22 18:31 ` Nicolas Pitre
2013-07-22 18:34 ` Ben Dooks
2013-07-19 14:01 ` Jon Medhurst (Tixy)
2013-07-19 14:05 ` Russell King - ARM Linux
2013-07-19 14:50 ` Ben Dooks
2013-07-19 14:56 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719110947.GD24642@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).