From mboxrd@z Thu Jan  1 00:00:00 1970
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
Date: Fri, 19 Jul 2013 12:09:47 +0100
Subject: alignment handler instruction endian-ness
In-Reply-To: <51E91BE5.8070809@codethink.co.uk>
References: <51E91BE5.8070809@codethink.co.uk>
Message-ID: <20130719110947.GD24642@n2100.arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Fri, Jul 19, 2013 at 11:58:45AM +0100, Ben Dooks wrote:
> I ran in to an issue with the alignment handler when running BE8 where
> it loads instructions and fails to swap.
>
> Is there a better way of swapping instructions for ARM when loading
> from arbitrary places? Have I missed any other places this could happen?

Maybe we need a macro which deals with this automatically?

	arm_instr_to_cpu(x)
	thumb_instr_to_cpu(x)

These should probably make use of the swab*() macros when an endian swap
is needed.

> The following patch is my first attempt at solving the problem for the
> alignment handler:

I'd suggest checking this with sparse too - you have some type errors here.