linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v2] ARM: i.MX pllv1: Implement set_rate
Date: Sat, 20 Jul 2013 15:31:04 +0400	[thread overview]
Message-ID: <20130720153104.96b6723a20bde172a8ea1ba1@mail.ru> (raw)
In-Reply-To: <20130720111639.GA29785@pengutronix.de>

On Sat, 20 Jul 2013 13:16:39 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:

> On Sat, Jul 20, 2013 at 12:29:35PM +0400, Alexander Shiyan wrote:
> > This patch implements frequency change for i.MX pllv1.
> > Selection of the values of the registers is not optimal, since is
> > made by simple enumeration of all possible values.
> 
> You do not mention why you want to adjust the rate. Normally we've been
> happy with the static values from the bootloader.

For CPUfreq.
Only one barrier to make it workable.

[...]
> > +	/* Avoid i.MX27 TO2 SPCTL0 bug */
> > +	if (cpu_is_mx27() && (mx27_revision() == IMX_CHIP_REVISION_2_0))
> > +		writel(reg, pll->base);
> 
> I remember this was fixed and got lost. If you want to have fixed it
> again this should be a separate paatch along with a description of the
> bug in the commit log.

This part of the patch can be completely removed ;)
I'm more interested in a more efficient algorithm for finding the best
values for the PLL.

[...]

-- 
Alexander Shiyan <shc_work@mail.ru>

  reply	other threads:[~2013-07-20 11:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-20  8:29 [RFC v2] ARM: i.MX pllv1: Implement set_rate Alexander Shiyan
2013-07-20 11:16 ` Sascha Hauer
2013-07-20 11:31   ` Alexander Shiyan [this message]
2013-07-20 11:58     ` Sascha Hauer
2013-07-20 12:18       ` Alexander Shiyan
2013-07-21 12:37         ` Sascha Hauer
2013-07-22 15:18           ` Alexander Shiyan
2013-07-22 15:24             ` Lucas Stach
2013-07-22 15:40               ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130720153104.96b6723a20bde172a8ea1ba1@mail.ru \
    --to=shc_work@mail.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).