From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Wed, 24 Jul 2013 15:03:15 -0400 Subject: Do we have people interested in device tree janitoring / cleanup? In-Reply-To: <51F01D64.9060609@gmail.com> References: <51F01D64.9060609@gmail.com> Message-ID: <20130724190315.GC23879@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 24, 2013 at 01:31:00PM -0500, Rob Herring wrote: > On 07/24/2013 10:27 AM, Olof Johansson wrote: > > Every now and then I come across a binding that's just done Wrong(tm), > > merged through a submaintainer tree and hasn't seen proper review -- > > if it had, it wouldn't look the way it does. It's something we're > > starting to address now since there's more people stepping up to be > > maintainers, but there's a backlog of bad bindings already merged. > > > > Often they are produced by translating the platform_data structures > > directly over into device-tree properties without consideration to > > describing the hardware or usual conventions, using key/value pairs > > instead of boolean properties, etc. > > > > Getting involved in cleaning up these kind of bindings is a great way > > to learn "the ways of device tree" for someone that has interest in > > that. > > > > Latest find in this area is the Maxim 8925 bindings, that I came > > across since they caused a compile warning on some defconfig. I'll > > post a patch to address the warning but if someone else feels like > > fixing the bindings on top of it that would be appreciated! > > Are they documented typically? Can we at a minimum update the > documentation with a big fat warning to not use or propagate the crap. > Or move the binding doc file to a fixme directory. I agree, in order to do the janitorial work (which I'm not opposed to helping with), we need a way to mark stable bindings. fwiw, we could do a separate commit (like the kernel version commit) where the only change is marking a binding as stable, and is obvious from a 'git log --oneline'. eg: ---->8------ >>From 65c069678cdbd5aaa6aca0d4062dab6eb9f9904c Mon Sep 17 00:00:00 2001 From: Jason Cooper Date: Wed, 24 Jul 2013 18:49:28 +0000 Subject: [PATCH] DT: binding: stable: gpio-regulator A whole bunch of folks reviewed this and think it kicks ass. List-of-people-responsible-for-this-travesty: ... Signed-off-by: Jason Cooper --- Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt index 63c6598..35ec635 100644 --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt @@ -1,3 +1,5 @@ +Binding status: Stable + GPIO controlled regulators Required properties: -- 1.8.3.2