From mboxrd@z Thu Jan 1 00:00:00 1970 From: davidb@codeaurora.org (David Brown) Date: Wed, 24 Jul 2013 13:30:03 -0700 Subject: [PATCH 2/4] msm_serial: Fix sparse warnings In-Reply-To: <1374691051-28544-3-git-send-email-sboyd@codeaurora.org> References: <1374691051-28544-1-git-send-email-sboyd@codeaurora.org> <1374691051-28544-3-git-send-email-sboyd@codeaurora.org> Message-ID: <20130724203003.GC10926@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 24, 2013 at 11:37:29AM -0700, Stephen Boyd wrote: >drivers/tty/serial/msm_serial.c:302:6: warning: symbol 'msm_set_mctrl' was >not declared. Should it be static? >drivers/tty/serial/msm_serial.c:597:17: warning: incorrect type in argument 2 >(different address spaces) >drivers/tty/serial/msm_serial.c:597:17: expected void volatile [noderef] *addr >drivers/tty/serial/msm_serial.c:597:17: got unsigned int * >drivers/tty/serial/msm_serial.c:608:33: warning: incorrect type in argument 1 >(different address spaces) >drivers/tty/serial/msm_serial.c:608:33: expected void volatile [noderef] *addr >drivers/tty/serial/msm_serial.c:608:33: got unsigned int *gsbi_base >drivers/tty/serial/msm_serial.c:648:37: warning: incorrect type in assignment >(different address spaces) >drivers/tty/serial/msm_serial.c:648:37: expected unsigned int *gsbi_base >drivers/tty/serial/msm_serial.c:648:37: got void [noderef] * > >Mark the ioremapped memory as __iomem and use writel instead of >iowrite because we're not dealing with PCI devices. Also, mark >msm_set_mctrl() static because it isn't used outside this file. > >Signed-off-by: Stephen Boyd >--- > drivers/tty/serial/msm_serial.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) Acked-by: David Brown -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation