From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: fixup argument order when setting VCO parameters
Date: Thu, 25 Jul 2013 10:44:16 -0700 [thread overview]
Message-ID: <20130725174416.7598.73819@quantum> (raw)
In-Reply-To: <51F0F035.8010705@arm.com>
Quoting Jonathan Austin (2013-07-25 02:30:29)
> On 24/07/13 20:32, Linus Walleij wrote:
> > On Tue, Jul 23, 2013 at 5:42 PM, Jonathan Austin
> > <jonathan.austin@arm.com> wrote:
> >
> >> The order of arguments in the call to vco_set() for the ICST clocks appears to
> >> have been switched in error, which results in the VCO not being initialised
> >> correctly. This in turn stops the integrated LCD on things like Integrator/CP
> >> from working correctly.
> >>
> >> This patch fixes the order and restores the expected functionality.
> >>
> >> Cc: Linus Walleij <linus.walleij@linaro.org>
> >> Cc: Mike Turquette <mturquette@linaro.org>
> >> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
> >
> > Good catch! Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > You should probably mark this for stable as well.
> >
>
> Mike, will you add Cc: stable when you take the fix or shall I resubmit
> the patch somehow else?
I'll add it.
Regards,
Mike
next prev parent reply other threads:[~2013-07-25 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 15:42 [PATCH 0/2] Restore Integrator/CP CLCD to fully working state Jonathan Austin
2013-07-23 15:42 ` [PATCH 1/2] ARM: integrator_cp: Set LCD{0, 1} enable lines when turning on CLCD Jonathan Austin
2013-08-15 15:41 ` [PATCH 1/2] ARM: integrator_cp: Set LCD{0,1} " Jonathan Austin
2013-08-28 7:29 ` Linus Walleij
2013-07-23 15:42 ` [PATCH 2/2] clk: fixup argument order when setting VCO parameters Jonathan Austin
2013-07-24 19:32 ` Linus Walleij
2013-07-25 9:30 ` Jonathan Austin
2013-07-25 9:33 ` Linus Walleij
2013-07-25 9:36 ` Jonathan Austin
2013-07-25 14:01 ` Linus Walleij
2013-07-25 17:44 ` Mike Turquette [this message]
2013-07-29 11:01 ` Jonathan Austin
2013-07-24 23:26 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725174416.7598.73819@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).