* BUG() issues with big-endian @ 2013-07-25 14:42 Ben Dooks 2013-07-25 14:42 ` [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic Ben Dooks 2013-07-25 14:42 ` [PATCH 2/2] ARM: fix BUG() detection Ben Dooks 0 siblings, 2 replies; 7+ messages in thread From: Ben Dooks @ 2013-07-25 14:42 UTC (permalink / raw) To: linux-arm-kernel Following Dave Martin's point over the is_valid_bugaddr() it was found that both is_valid_bugaddr() is broken w.r.t to BE8 as well as the BUG() macro creation. These two patches fix the problems. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic 2013-07-25 14:42 BUG() issues with big-endian Ben Dooks @ 2013-07-25 14:42 ` Ben Dooks 2013-07-25 15:57 ` Dave Martin 2013-07-25 14:42 ` [PATCH 2/2] ARM: fix BUG() detection Ben Dooks 1 sibling, 1 reply; 7+ messages in thread From: Ben Dooks @ 2013-07-25 14:42 UTC (permalink / raw) To: linux-arm-kernel Currently BUG() uses .word or .hword to create the necessary illegal instructions. However if we are building BE8 then these get swapped by the linker into different illegal instructions in the text. Change to using .inst and .inst.w to create the instructions and mark them as instructions so that the linker acts correctly. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- arch/arm/include/asm/bug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h index 7af5c6c..b95da52 100644 --- a/arch/arm/include/asm/bug.h +++ b/arch/arm/include/asm/bug.h @@ -12,10 +12,10 @@ */ #ifdef CONFIG_THUMB2_KERNEL #define BUG_INSTR_VALUE 0xde02 -#define BUG_INSTR_TYPE ".hword " +#define BUG_INSTR_TYPE ".inst.w " #else #define BUG_INSTR_VALUE 0xe7f001f2 -#define BUG_INSTR_TYPE ".word " +#define BUG_INSTR_TYPE ".inst " #endif -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic 2013-07-25 14:42 ` [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic Ben Dooks @ 2013-07-25 15:57 ` Dave Martin 2013-07-25 16:05 ` Ben Dooks 0 siblings, 1 reply; 7+ messages in thread From: Dave Martin @ 2013-07-25 15:57 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 25, 2013 at 03:42:36PM +0100, Ben Dooks wrote: > Currently BUG() uses .word or .hword to create the necessary illegal > instructions. However if we are building BE8 then these get swapped > by the linker into different illegal instructions in the text. In the case of Thumb, the resulting instruction is actually not illegal, which is even worse... > Change to using .inst and .inst.w to create the instructions and mark > them as instructions so that the linker acts correctly. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/arm/include/asm/bug.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h > index 7af5c6c..b95da52 100644 > --- a/arch/arm/include/asm/bug.h > +++ b/arch/arm/include/asm/bug.h > @@ -12,10 +12,10 @@ > */ > #ifdef CONFIG_THUMB2_KERNEL > #define BUG_INSTR_VALUE 0xde02 > -#define BUG_INSTR_TYPE ".hword " > +#define BUG_INSTR_TYPE ".inst.w " > #else > #define BUG_INSTR_VALUE 0xe7f001f2 > -#define BUG_INSTR_TYPE ".word " > +#define BUG_INSTR_TYPE ".inst " > #endif There was some uncertainty a while ago about precisely which versions of gas support .inst. <asm/opcodes.h> implements an abstracted workaround for this issue, whereby you can emit instructions using the __inst*() macros, and the swabbing and assembler directives should be generated for you. The patch below ought to do this for BUG(), but I've only briefly build-tested it. Note that the disassembly of the injected instructions in .o files can be a bit confusing, because they are marked as data, do ld --be8 doesn't swab them (unlike the instructions, which do get swabbed). objdump may also do extra swabbing during disassembly. You can sanity-check what is really in the image by dumping the text section of vmlinux with objdump -s. The change to <asm/opcodes.h> is due to a missing include which is really required for correctness, but which didn't show up without the <asm/bug.h> change (this causes opcodes.h to get included way more often than is otherwise the case). Cheers ---Dave diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h index 7af5c6c..e36fe85 100644 --- a/arch/arm/include/asm/bug.h +++ b/arch/arm/include/asm/bug.h @@ -2,6 +2,7 @@ #define _ASMARM_BUG_H #include <linux/linkage.h> +#include <asm/opcodes.h> #ifdef CONFIG_BUG @@ -12,15 +13,15 @@ */ #ifdef CONFIG_THUMB2_KERNEL #define BUG_INSTR_VALUE 0xde02 -#define BUG_INSTR_TYPE ".hword " +#define __BUG_INSTR __inst_thumb16(BUG_INSTR_VALUE) #else #define BUG_INSTR_VALUE 0xe7f001f2 -#define BUG_INSTR_TYPE ".word " +#define __BUG_INSTR __inst_arm(BUG_INSTR_VALUE) #endif -#define BUG() _BUG(__FILE__, __LINE__, BUG_INSTR_VALUE) -#define _BUG(file, line, value) __BUG(file, line, value) +#define BUG() _BUG(__FILE__, __LINE__) +#define _BUG(file, line) __BUG(file, line) #ifdef CONFIG_DEBUG_BUGVERBOSE @@ -31,9 +32,9 @@ * avoid multiple copies of the string appearing in the kernel image. */ -#define __BUG(__file, __line, __value) \ +#define __BUG(__file, __line) \ do { \ - asm volatile("1:\t" BUG_INSTR_TYPE #__value "\n" \ + asm volatile("1:\t" __BUG_INSTR "\n" \ ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" \ "2:\t.asciz " #__file "\n" \ ".popsection\n" \ @@ -46,9 +47,9 @@ do { \ #else /* not CONFIG_DEBUG_BUGVERBOSE */ -#define __BUG(__file, __line, __value) \ +#define __BUG(__file, __line) \ do { \ - asm volatile(BUG_INSTR_TYPE #__value); \ + asm volatile(__BUG_INSTR) \ unreachable(); \ } while (0) #endif /* CONFIG_DEBUG_BUGVERBOSE */ diff --git a/arch/arm/include/asm/opcodes.h b/arch/arm/include/asm/opcodes.h index e796c59..e94ebfd 100644 --- a/arch/arm/include/asm/opcodes.h +++ b/arch/arm/include/asm/opcodes.h @@ -11,6 +11,8 @@ #ifndef __ASSEMBLY__ #include <linux/linkage.h> +#include <linux/types.h> + extern asmlinkage unsigned int arm_check_condition(u32 opcode, u32 psr); #endif ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic 2013-07-25 15:57 ` Dave Martin @ 2013-07-25 16:05 ` Ben Dooks 2013-07-25 17:54 ` Dave Martin 0 siblings, 1 reply; 7+ messages in thread From: Ben Dooks @ 2013-07-25 16:05 UTC (permalink / raw) To: linux-arm-kernel On 25/07/13 16:57, Dave Martin wrote: > On Thu, Jul 25, 2013 at 03:42:36PM +0100, Ben Dooks wrote: >> Currently BUG() uses .word or .hword to create the necessary illegal >> instructions. However if we are building BE8 then these get swapped >> by the linker into different illegal instructions in the text. > > In the case of Thumb, the resulting instruction is actually not illegal, > which is even worse... > >> Change to using .inst and .inst.w to create the instructions and mark >> them as instructions so that the linker acts correctly. >> >> Signed-off-by: Ben Dooks<ben.dooks@codethink.co.uk> >> --- >> arch/arm/include/asm/bug.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h >> index 7af5c6c..b95da52 100644 >> --- a/arch/arm/include/asm/bug.h >> +++ b/arch/arm/include/asm/bug.h >> @@ -12,10 +12,10 @@ >> */ >> #ifdef CONFIG_THUMB2_KERNEL >> #define BUG_INSTR_VALUE 0xde02 >> -#define BUG_INSTR_TYPE ".hword " >> +#define BUG_INSTR_TYPE ".inst.w " >> #else >> #define BUG_INSTR_VALUE 0xe7f001f2 >> -#define BUG_INSTR_TYPE ".word " >> +#define BUG_INSTR_TYPE ".inst " >> #endif > > There was some uncertainty a while ago about precisely which versions of > gas support .inst. > > <asm/opcodes.h> implements an abstracted workaround for this issue, > whereby you can emit instructions using the __inst*() macros, and > the swabbing and assembler directives should be generated for you. > > The patch below ought to do this for BUG(), but I've only briefly > build-tested it. > > > Note that the disassembly of the injected instructions in .o files > can be a bit confusing, because they are marked as data, do ld --be8 > doesn't swab them (unlike the instructions, which do get swabbed). > objdump may also do extra swabbing during disassembly. > > You can sanity-check what is really in the image by dumping the text > section of vmlinux with objdump -s. > > > The change to<asm/opcodes.h> is due to a missing include which is > really required for correctness, but which didn't show up without > the<asm/bug.h> change (this causes opcodes.h to get included way > more often than is otherwise the case). > > Cheers > ---Dave Given it was added ~2006 according the mailing lists I have seen, then it should be ok to use for building modern kernels with. I think the use of .inst and .inst.w is a better solution than having the code having bits of it marked as data. > > diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h > index 7af5c6c..e36fe85 100644 > --- a/arch/arm/include/asm/bug.h > +++ b/arch/arm/include/asm/bug.h > @@ -2,6 +2,7 @@ > #define _ASMARM_BUG_H > > #include<linux/linkage.h> > +#include<asm/opcodes.h> > > #ifdef CONFIG_BUG > > @@ -12,15 +13,15 @@ > */ > #ifdef CONFIG_THUMB2_KERNEL > #define BUG_INSTR_VALUE 0xde02 > -#define BUG_INSTR_TYPE ".hword " > +#define __BUG_INSTR __inst_thumb16(BUG_INSTR_VALUE) > #else > #define BUG_INSTR_VALUE 0xe7f001f2 > -#define BUG_INSTR_TYPE ".word " > +#define __BUG_INSTR __inst_arm(BUG_INSTR_VALUE) > #endif > > > -#define BUG() _BUG(__FILE__, __LINE__, BUG_INSTR_VALUE) > -#define _BUG(file, line, value) __BUG(file, line, value) > +#define BUG() _BUG(__FILE__, __LINE__) > +#define _BUG(file, line) __BUG(file, line) > > #ifdef CONFIG_DEBUG_BUGVERBOSE > > @@ -31,9 +32,9 @@ > * avoid multiple copies of the string appearing in the kernel image. > */ > > -#define __BUG(__file, __line, __value) \ > +#define __BUG(__file, __line) \ > do { \ > - asm volatile("1:\t" BUG_INSTR_TYPE #__value "\n" \ > + asm volatile("1:\t" __BUG_INSTR "\n" \ > ".pushsection .rodata.str, \"aMS\", %progbits, 1\n" \ > "2:\t.asciz " #__file "\n" \ > ".popsection\n" \ > @@ -46,9 +47,9 @@ do { \ > > #else /* not CONFIG_DEBUG_BUGVERBOSE */ > > -#define __BUG(__file, __line, __value) \ > +#define __BUG(__file, __line) \ > do { \ > - asm volatile(BUG_INSTR_TYPE #__value); \ > + asm volatile(__BUG_INSTR) \ > unreachable(); \ > } while (0) > #endif /* CONFIG_DEBUG_BUGVERBOSE */ > diff --git a/arch/arm/include/asm/opcodes.h b/arch/arm/include/asm/opcodes.h > index e796c59..e94ebfd 100644 > --- a/arch/arm/include/asm/opcodes.h > +++ b/arch/arm/include/asm/opcodes.h > @@ -11,6 +11,8 @@ > > #ifndef __ASSEMBLY__ > #include<linux/linkage.h> > +#include<linux/types.h> > + > extern asmlinkage unsigned int arm_check_condition(u32 opcode, u32 psr); > #endif > -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic 2013-07-25 16:05 ` Ben Dooks @ 2013-07-25 17:54 ` Dave Martin 2013-07-26 10:48 ` Dave Martin 0 siblings, 1 reply; 7+ messages in thread From: Dave Martin @ 2013-07-25 17:54 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 25, 2013 at 05:05:03PM +0100, Ben Dooks wrote: > On 25/07/13 16:57, Dave Martin wrote: > >On Thu, Jul 25, 2013 at 03:42:36PM +0100, Ben Dooks wrote: > >>Currently BUG() uses .word or .hword to create the necessary illegal > >>instructions. However if we are building BE8 then these get swapped > >>by the linker into different illegal instructions in the text. > > > >In the case of Thumb, the resulting instruction is actually not illegal, > >which is even worse... > > > >>Change to using .inst and .inst.w to create the instructions and mark > >>them as instructions so that the linker acts correctly. > >> > >>Signed-off-by: Ben Dooks<ben.dooks@codethink.co.uk> > >>--- > >> arch/arm/include/asm/bug.h | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >>diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h > >>index 7af5c6c..b95da52 100644 > >>--- a/arch/arm/include/asm/bug.h > >>+++ b/arch/arm/include/asm/bug.h > >>@@ -12,10 +12,10 @@ > >> */ > >> #ifdef CONFIG_THUMB2_KERNEL > >> #define BUG_INSTR_VALUE 0xde02 > >>-#define BUG_INSTR_TYPE ".hword " > >>+#define BUG_INSTR_TYPE ".inst.w " > >> #else > >> #define BUG_INSTR_VALUE 0xe7f001f2 > >>-#define BUG_INSTR_TYPE ".word " > >>+#define BUG_INSTR_TYPE ".inst " > >> #endif > > > >There was some uncertainty a while ago about precisely which versions of > >gas support .inst. > > > ><asm/opcodes.h> implements an abstracted workaround for this issue, > >whereby you can emit instructions using the __inst*() macros, and > >the swabbing and assembler directives should be generated for you. > > > >The patch below ought to do this for BUG(), but I've only briefly > >build-tested it. > > > > > >Note that the disassembly of the injected instructions in .o files > >can be a bit confusing, because they are marked as data, do ld --be8 > >doesn't swab them (unlike the instructions, which do get swabbed). > >objdump may also do extra swabbing during disassembly. > > > >You can sanity-check what is really in the image by dumping the text > >section of vmlinux with objdump -s. > > > > > >The change to<asm/opcodes.h> is due to a missing include which is > >really required for correctness, but which didn't show up without > >the<asm/bug.h> change (this causes opcodes.h to get included way > >more often than is otherwise the case). > > > >Cheers > >---Dave > > Given it was added ~2006 according the mailing lists I have seen, then > it should be ok to use for building modern kernels with. I think the > use of .inst and .inst.w is a better solution than having the code > having bits of it marked as data. Of course it is. But this discussion can be decoupled from bug.h: if we decide to migrate to .inst, we can do that in one place in opcodes.h, no? Otherwise, we have multiple fixes to apply when we decide to make that change. Cheers ---Dave ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic 2013-07-25 17:54 ` Dave Martin @ 2013-07-26 10:48 ` Dave Martin 0 siblings, 0 replies; 7+ messages in thread From: Dave Martin @ 2013-07-26 10:48 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 25, 2013 at 06:54:56PM +0100, Dave Martin wrote: > On Thu, Jul 25, 2013 at 05:05:03PM +0100, Ben Dooks wrote: > > On 25/07/13 16:57, Dave Martin wrote: > > >On Thu, Jul 25, 2013 at 03:42:36PM +0100, Ben Dooks wrote: > > >>Currently BUG() uses .word or .hword to create the necessary illegal > > >>instructions. However if we are building BE8 then these get swapped > > >>by the linker into different illegal instructions in the text. > > > > > >In the case of Thumb, the resulting instruction is actually not illegal, > > >which is even worse... > > > > > >>Change to using .inst and .inst.w to create the instructions and mark > > >>them as instructions so that the linker acts correctly. > > >> > > >>Signed-off-by: Ben Dooks<ben.dooks@codethink.co.uk> > > >>--- > > >> arch/arm/include/asm/bug.h | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >>diff --git a/arch/arm/include/asm/bug.h b/arch/arm/include/asm/bug.h > > >>index 7af5c6c..b95da52 100644 > > >>--- a/arch/arm/include/asm/bug.h > > >>+++ b/arch/arm/include/asm/bug.h > > >>@@ -12,10 +12,10 @@ > > >> */ > > >> #ifdef CONFIG_THUMB2_KERNEL > > >> #define BUG_INSTR_VALUE 0xde02 > > >>-#define BUG_INSTR_TYPE ".hword " > > >>+#define BUG_INSTR_TYPE ".inst.w " > > >> #else > > >> #define BUG_INSTR_VALUE 0xe7f001f2 > > >>-#define BUG_INSTR_TYPE ".word " > > >>+#define BUG_INSTR_TYPE ".inst " > > >> #endif > > > > > >There was some uncertainty a while ago about precisely which versions of > > >gas support .inst. > > > > > ><asm/opcodes.h> implements an abstracted workaround for this issue, > > >whereby you can emit instructions using the __inst*() macros, and > > >the swabbing and assembler directives should be generated for you. > > > > > >The patch below ought to do this for BUG(), but I've only briefly > > >build-tested it. > > > > > > > > >Note that the disassembly of the injected instructions in .o files > > >can be a bit confusing, because they are marked as data, do ld --be8 > > >doesn't swab them (unlike the instructions, which do get swabbed). > > >objdump may also do extra swabbing during disassembly. > > > > > >You can sanity-check what is really in the image by dumping the text > > >section of vmlinux with objdump -s. > > > > > > > > >The change to<asm/opcodes.h> is due to a missing include which is > > >really required for correctness, but which didn't show up without > > >the<asm/bug.h> change (this causes opcodes.h to get included way > > >more often than is otherwise the case). > > > > > >Cheers > > >---Dave > > > > Given it was added ~2006 according the mailing lists I have seen, then > > it should be ok to use for building modern kernels with. I think the > > use of .inst and .inst.w is a better solution than having the code > > having bits of it marked as data. > > Of course it is. But this discussion can be decoupled from bug.h: > if we decide to migrate to .inst, we can do that in one place in > opcodes.h, no? > > Otherwise, we have multiple fixes to apply when we decide to make > that change. A quick follow-up on that: I found I have a random old binutils knocking around which is post-2006 and lacks .inst: $ arm-elf-eabi-as --version GNU assembler (GNU Binutils) 2.19.1 Copyright 2007 Free Software Foundation, Inc. This program is free software; you may redistribute it under the terms of the GNU General Public License version 3 or later. This program has absolutely no warranty. This assembler was configured for a target of `arm-elf-eabi'. $ echo .inst 0 | arm-elf-eabi-as {standard input}: Assembler messages: {standard input}:1: Error: unknown pseudo-op: `.inst' Maybe .inst never made it onto that release branch. This goes a small way to explaining why my disk is so full, anyway. I won't comment on whether it's wise to carry on using tools that old, but I note that it can build current mainline, except for some newer, v7-specific configurations. bug.h is hardly v7-specific. Because a workaround for the lack of .inst already exists, I think it would be execessive to cut off backward tool compaitiblity for all configurations just for this minor, solved issue. Cheers ---Dave ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] ARM: fix BUG() detection 2013-07-25 14:42 BUG() issues with big-endian Ben Dooks 2013-07-25 14:42 ` [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic Ben Dooks @ 2013-07-25 14:42 ` Ben Dooks 1 sibling, 0 replies; 7+ messages in thread From: Ben Dooks @ 2013-07-25 14:42 UTC (permalink / raw) To: linux-arm-kernel The detection of the instruction used by BUG() did not take into account the differences in endian-ness between instruction and data. Change the code to use the relevant helpers in <asm/opcodes.h> to translate the endian-ness of the instructions. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- arch/arm/kernel/traps.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c index cb67b04..ae2d828 100644 --- a/arch/arm/kernel/traps.c +++ b/arch/arm/kernel/traps.c @@ -344,15 +344,17 @@ void arm_notify_die(const char *str, struct pt_regs *regs, int is_valid_bugaddr(unsigned long pc) { #ifdef CONFIG_THUMB2_KERNEL - unsigned short bkpt; + u16 bkpt; + u16 insn = __opcode_to_mem_thumb16(BUG_INSTR_VALUE); #else - unsigned long bkpt; + u32 bkpt; + u32 insn = __opcode_to_mem_arm(BUG_INSTR_VALUE); #endif if (probe_kernel_address((unsigned *)pc, bkpt)) return 0; - return bkpt == BUG_INSTR_VALUE; + return bkpt == insn; } #endif -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-07-26 10:48 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-07-25 14:42 BUG() issues with big-endian Ben Dooks 2013-07-25 14:42 ` [PATCH 1/2] ARM: Correct BUG() assembly to ensure it is endian-agnostic Ben Dooks 2013-07-25 15:57 ` Dave Martin 2013-07-25 16:05 ` Ben Dooks 2013-07-25 17:54 ` Dave Martin 2013-07-26 10:48 ` Dave Martin 2013-07-25 14:42 ` [PATCH 2/2] ARM: fix BUG() detection Ben Dooks
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).