From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: Location for a kind of GPIO bus driver
Date: Fri, 26 Jul 2013 08:01:53 -0400 [thread overview]
Message-ID: <20130726120153.GE29916@titan.lakedaemon.net> (raw)
In-Reply-To: <20130725221615.GA30881@kroah.com>
On Thu, Jul 25, 2013 at 03:16:15PM -0700, Greg KH wrote:
> On Thu, Jul 25, 2013 at 11:46:42PM +0200, Linus Walleij wrote:
> > On Tue, Jul 23, 2013 at 5:18 PM, Simon Guinot <simon.guinot@sequanux.org> wrote:
> >
> > > (...) I am
> > > thinking about moving the GPIO extension bus support into a separate
> > > driver. The problem is that I can't find a proper location for a such
> > > driver. AFAIK, it doesn't fit with anything existing supported by Linux.
> > > Maybe I should consider drivers/bus ? Or even drivers/misc ?
> >
> > This is a question to Greg, the device core maintainer.
> > AFAICT they go into drivers/base/foo-bus.c
>
> No, specific bus code does not go in drivers/base/ it goes where the
> rest of the subsystem lives.
We were thinking drivers/bus since it is addressable and has multiple
devices hanging off of it (leds, power management).
However, since each device is essentially an external gpio, drivers/gpio
might be more appropriate. It's not a gpio expander, more of an
enhanced gpio controller (led 1, brightness 7)
> > In this case I would first consider using MFD though,
> > please make a case for why this is not simply a multi
> > function device with a few cells (== platform devices).
>
> I agree with this as well.
To quote Simon from a different response:
> I will definitively have a closer look at mfd. But as I understand,
> mfd is more oriented platform device and resources. Here, the device
> don't expose some memory regions but rather methods to configure a
> CPLD through GPIOs. I am not sure how it can work with the mfd
> framework.
thx,
Jason.
prev parent reply other threads:[~2013-07-26 12:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 15:18 Location for a kind of GPIO bus driver Simon Guinot
2013-07-24 18:19 ` Jason Cooper
2013-07-25 15:49 ` Simon Guinot
2013-07-25 16:03 ` Jason Cooper
2013-07-26 8:56 ` Simon Guinot
2013-07-26 11:27 ` Jason Cooper
2013-07-26 16:18 ` Arnd Bergmann
2013-07-25 21:46 ` Linus Walleij
2013-07-25 22:16 ` Greg KH
2013-07-26 12:01 ` Jason Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726120153.GE29916@titan.lakedaemon.net \
--to=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox