linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] clk: export __clk_get_flags for modular clock providers
Date: Tue, 30 Jul 2013 16:03:24 -0700	[thread overview]
Message-ID: <20130730230324.5270.4519@quantum> (raw)
In-Reply-To: <51D5DEE7.2070400@ti.com>

Quoting Luciano Coelho (2013-07-04 13:45:27)
> Hi,
> 
> On 04/15/2013 09:59 AM, Sebastian Hesselbarth wrote:
> > The common clock api provides some helpers for clk-providers but does
> > not export these helpers. This hinders clk-providers to be built as modules.
> > This patch adds __clk_get_flags() to the list of exported symbols.
> >
> > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > ---
> > Cc: Mike Turquette <mturquette@linaro.org>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-kernel at vger.kernel.org
> > ---
> >   drivers/clk/clk.c |    1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index ed87b24..3e478b8 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -450,6 +450,7 @@ unsigned long __clk_get_flags(struct clk *clk)
> >   {
> >       return !clk ? 0 : clk->flags;
> >   }
> > +EXPORT_SYMBOL_GPL(__clk_get_flags);
> >
> >   bool __clk_is_enabled(struct clk *clk)
> >   {
> >
> 
> I think this got merged slightly wrong.  The EXPORT_SYMBOL_GPL macro 
> came under clk_unprepare_unused_subtree() instead of under 
> __clk_get_flags():
> 
> 
> Of course this is not that important, but it's a bit confusing when you 
> look at the code.

Thanks for pointing this out. I've fixed it up.

Regards,
Mike

> 
> --
> Cheers,
> Luca.

      reply	other threads:[~2013-07-30 23:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15  6:59 [PATCH RESEND] clk: export __clk_get_flags for modular clock providers Sebastian Hesselbarth
2013-07-04 20:45 ` Luciano Coelho
2013-07-30 23:03   ` Mike Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730230324.5270.4519@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).