From: htejun@gmail.com (Tejun Heo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] chipidea: Use devm_request_irq()
Date: Wed, 31 Jul 2013 09:42:15 -0400 [thread overview]
Message-ID: <20130731134215.GS2810@htj.dyndns.org> (raw)
In-Reply-To: <20130731132708.GQ9858@sirena.org.uk>
Hello,
On Wed, Jul 31, 2013 at 02:27:08PM +0100, Mark Brown wrote:
> It's really only interrupts that affect most devices - if there's DMA or
> anything going on after the remove() then as you said earlier the driver
> is probably doing something wrong.
Hmmm... it depends on the specific driver is converted but if the
deactivation sequence - shutting down of command engine - is also
handled by devm as in libata and if you have non-devres resource free
in the exit path, you have the same problem. Again, in general,
tearing things down in the order which isn't the reverse of allocation
is a bad idea. Adhering to the order isn't that hard and will result
in far less craziness in the long term.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-07-31 13:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375232669-27846-1-git-send-email-festevam@gmail.com>
[not found] ` <1375232669-27846-2-git-send-email-festevam@gmail.com>
[not found] ` <20130731073306.GZ1754@pengutronix.de>
[not found] ` <20130731082054.GF8540@nchen-desktop>
[not found] ` <20130731084645.GB1754@pengutronix.de>
[not found] ` <20130731090512.GD9858@sirena.org.uk>
2013-07-31 9:44 ` [PATCH 2/2] chipidea: Use devm_request_irq() Uwe Kleine-König
2013-07-31 9:54 ` Tejun Heo
2013-07-31 10:28 ` Uwe Kleine-König
2013-07-31 10:41 ` Tejun Heo
2013-07-31 11:18 ` Mark Brown
2013-07-31 11:32 ` Tejun Heo
2013-07-31 11:50 ` Mark Brown
2013-07-31 11:55 ` Tejun Heo
2013-07-31 13:27 ` Mark Brown
2013-07-31 13:42 ` Tejun Heo [this message]
2013-07-31 13:57 ` Mark Brown
2013-07-31 14:07 ` Tejun Heo
2013-07-31 15:25 ` Mark Brown
2013-07-31 15:29 ` Tejun Heo
2013-07-31 16:52 ` Mark Brown
2013-07-31 13:55 ` Peter Chen
2013-07-31 14:15 ` Tejun Heo
2013-08-01 1:33 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731134215.GS2810@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).