public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: imx: work around select input quirk
Date: Thu, 1 Aug 2013 16:32:23 +0800	[thread overview]
Message-ID: <20130801083221.GA32696@nchen-desktop> (raw)
In-Reply-To: <CAAQ0ZWQajP49jM_0wqvqmuv19ZcSQ_1QUzgxfsBYzKU_5w0bMA@mail.gmail.com>

On Thu, Aug 01, 2013 at 03:08:06PM +0800, Shawn Guo wrote:
> On 1 August 2013 14:51, Peter Chen <peter.chen@freescale.com> wrote:
> > Shawn, input_reg[i] may be 0 if the fixed one at first register of IOMUXC
> 
> Ah, yes.  Now select input register at offset 0 becomes possible.  I
> will try to fix it.
> 
> Regardless of this, does the series work for you?
> 
Yes, it works, you can add : Tested-by: Peter Chen <peter.chen@freescale.com>

I changed the second patch manually, have you changed the pin prefix
at arch/arm/boot/dts/imx6q-pinfunc.h?  At 3.10, it is MX6Q_XXX.

Besides, please add comments for u16 *input_reg at struct imx_pin_group.

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2013-08-01  8:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01  4:22 [PATCH 1/2] pinctrl: imx: work around select input quirk Shawn Guo
2013-08-01  4:22 ` [PATCH 2/2] ARM: dts: imx6q: add quirky select input for USB_OTG_ID Shawn Guo
2013-08-07 18:34   ` Linus Walleij
2013-08-08  1:27     ` Shawn Guo
2013-08-13  6:18       ` Linus Walleij
2013-08-01  6:51 ` [PATCH 1/2] pinctrl: imx: work around select input quirk Peter Chen
2013-08-01  7:08   ` Shawn Guo
2013-08-01  8:32     ` Peter Chen [this message]
2013-08-04 12:54       ` Shawn Guo
2013-08-05  1:14         ` Peter Chen
2013-08-05  3:26           ` Shawn Guo
2013-08-05  1:35             ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130801083221.GA32696@nchen-desktop \
    --to=peter.chen@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox