* [PATCH v2 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 [not found] <531356997.66774.1373571839852.JavaMail.apache@mail81.abv.bg> @ 2013-07-11 19:54 ` Santosh Shilimkar 2013-07-12 10:24 ` Dave Martin 0 siblings, 1 reply; 5+ messages in thread From: Santosh Shilimkar @ 2013-07-11 19:54 UTC (permalink / raw) To: linux-arm-kernel On Thursday 11 July 2013 03:43 PM, ?????? ???????? wrote: > > > > > > >-------- ?????????? ????? -------- > >??: Dave Martin > >???????: Re: [PATCH v2 1/2] ARM: OMAP: Add secure function omap_smc3() which > calling instruction smc #1 > >??: Pali Roh?r > >????????? ??: ?????, 2013, ??? 10 20:45:26 EEST > > > > > >On Wed, Jul 10, 2013 at 02:59:04PM +0200, Pali Roh?r wrote: > >> Other secure functions omap_smc1() and omap_smc2() calling instruction smc #0 > >> but Nokia RX-51 board needs to call smc #1 for PPA access. > >> > >> Signed-off-by: Ivaylo Dimitrov > >> Signed-off-by: Pali Roh?r > >> --- > >> arch/arm/mach-omap2/omap-secure.h | 1 + > >> arch/arm/mach-omap2/omap-smc.S | 22 +++++++++++++++++++++- > >> 2 files changed, 22 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h > >> index 0e72917..c4586f4 100644 > >> --- a/arch/arm/mach-omap2/omap-secure.h > >> +++ b/arch/arm/mach-omap2/omap-secure.h > >> @@ -51,6 +51,7 @@ > >> extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, > >> u32 arg1, u32 arg2, u32 arg3, u32 arg4); > >> extern u32 omap_smc2(u32 id, u32 falg, u32 pargs); > >> +extern u32 omap_smc3(u32 id, u32 process, u32 flag, u32 pargs); > >> extern phys_addr_t omap_secure_ram_mempool_base(void); > >> extern int omap_secure_ram_reserve_memblock(void); > >> > >> diff --git a/arch/arm/mach-omap2/omap-smc.S b/arch/arm/mach-omap2/omap-smc.S > >> index f6441c1..5c02b8d 100644 > >> --- a/arch/arm/mach-omap2/omap-smc.S > >> +++ b/arch/arm/mach-omap2/omap-smc.S > >> @@ -1,9 +1,11 @@ > >> /* > >> - * OMAP44xx secure APIs file. > >> + * OMAP34xx and OMAP44xx secure APIs file. > >> * > >> * Copyright (C) 2010 Texas Instruments, Inc. > >> * Written by Santosh Shilimkar > >> * > >> + * Copyright (C) 2012 Ivaylo Dimitrov > >> + * Copyright (C) 2013 Pali Roh?r > >> * > >> * This program is free software,you can redistribute it and/or modify > >> * it under the terms of the GNU General Public License version 2 as > >> @@ -54,6 +56,24 @@ ENTRY(omap_smc2) > >> ldmfd sp!, {r4-r12, pc} > >> ENDPROC(omap_smc2) > >> > >> +/** > >> + * u32 omap_smc3(u32 service_id, u32 process_id, u32 flag, u32 pargs) > >> + * Low level common routine for secure HAL and PPA APIs via smc #1 > >> + * r0 - @service_id: Secure Service ID > >> + * r1 - @process_id: Process ID > >> + * r2 - @flag: Flag to indicate the criticality of operation > >> + * r3 - @pargs: Physical address of parameter list > >> + */ > >> +ENTRY(omap_smc3) > >> + stmfd sp!, {r4-r12, lr} > > > >You don't need to save/restore r12. The ABI allows it to be clobbered > >across function calls. > > > >> + mov r12, r0 @ Copy the secure service ID > >> + mov r6, #0xff @ Indicate new Task call > >> + dsb > >> + dmb > > > >dsb synchronises a superset of what dmb synchronises, so the dmb here is > >not useful. > > > >In any case, any code calling this must flush the region addressed by > >r3 beforehand anyway, which will include a dsb as part of its semantics > >-- this is how you call it from rx51_secure_dispatcher(). > > > >So I think the dsb may not be needed here (?) > > > >Cheers > >---Dave > > > > > > Could be, but I wonder why almost all the kernel code(I am aware of) that uses SMC and is written by TI, is storing r12 and is using both DSB and DMB. See arch/arm/mach-omap2/sleep34xx.S or arch/arm/mach-omap2/omap-smc.S for examples. I'd rather play it safe and leave it that way, unless someone confirms the other code using SMC has extra DSB/DMB instructions too. I wouldn't risk passing invalid/stale data to the Secure Monitor to just save 8 bytes and barriers in a performance non-critical code which will be called only a couple of times during the boot-up process. r12 save/restore is a legacy from omap_smc2 in omap-smc.S, so I guess it can go away without much of a trouble. > Dave pointed out about the dsb and r12 to me in another thread. R12 can be easily removed but the DSB's were needed on OMAP for power sequencing. Without those, we have seen many issues. So you can leave the dsb's to be consistent with rest of the code. Regards Santosh P.S: Please sensibly wrap your message while replying. You reply apears like one single line and I needed to keep scrolling to read it. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 2013-07-11 19:54 ` [PATCH v2 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 Santosh Shilimkar @ 2013-07-12 10:24 ` Dave Martin 2013-08-04 8:45 ` [PATCH v3 " Pali Rohár 0 siblings, 1 reply; 5+ messages in thread From: Dave Martin @ 2013-07-12 10:24 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 11, 2013 at 03:54:34PM -0400, Santosh Shilimkar wrote: > On Thursday 11 July 2013 03:43 PM, ?????? ???????? wrote: > > > > > > > > > > > > >-------- ?????????? ????? -------- > > >??: Dave Martin > > >???????: Re: [PATCH v2 1/2] ARM: OMAP: Add secure function omap_smc3() which > > calling instruction smc #1 > > >??: Pali Roh?r > > >????????? ??: ?????, 2013, ??? 10 20:45:26 EEST > > > > > > > > >On Wed, Jul 10, 2013 at 02:59:04PM +0200, Pali Roh?r wrote: > > >> Other secure functions omap_smc1() and omap_smc2() calling instruction smc #0 > > >> but Nokia RX-51 board needs to call smc #1 for PPA access. > > >> > > >> Signed-off-by: Ivaylo Dimitrov > > >> Signed-off-by: Pali Roh?r > > >> --- > > >> arch/arm/mach-omap2/omap-secure.h | 1 + > > >> arch/arm/mach-omap2/omap-smc.S | 22 +++++++++++++++++++++- > > >> 2 files changed, 22 insertions(+), 1 deletion(-) > > >> > > >> diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h > > >> index 0e72917..c4586f4 100644 > > >> --- a/arch/arm/mach-omap2/omap-secure.h > > >> +++ b/arch/arm/mach-omap2/omap-secure.h > > >> @@ -51,6 +51,7 @@ > > >> extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, > > >> u32 arg1, u32 arg2, u32 arg3, u32 arg4); > > >> extern u32 omap_smc2(u32 id, u32 falg, u32 pargs); > > >> +extern u32 omap_smc3(u32 id, u32 process, u32 flag, u32 pargs); > > >> extern phys_addr_t omap_secure_ram_mempool_base(void); > > >> extern int omap_secure_ram_reserve_memblock(void); > > >> > > >> diff --git a/arch/arm/mach-omap2/omap-smc.S b/arch/arm/mach-omap2/omap-smc.S > > >> index f6441c1..5c02b8d 100644 > > >> --- a/arch/arm/mach-omap2/omap-smc.S > > >> +++ b/arch/arm/mach-omap2/omap-smc.S > > >> @@ -1,9 +1,11 @@ > > >> /* > > >> - * OMAP44xx secure APIs file. > > >> + * OMAP34xx and OMAP44xx secure APIs file. > > >> * > > >> * Copyright (C) 2010 Texas Instruments, Inc. > > >> * Written by Santosh Shilimkar > > >> * > > >> + * Copyright (C) 2012 Ivaylo Dimitrov > > >> + * Copyright (C) 2013 Pali Roh?r > > >> * > > >> * This program is free software,you can redistribute it and/or modify > > >> * it under the terms of the GNU General Public License version 2 as > > >> @@ -54,6 +56,24 @@ ENTRY(omap_smc2) > > >> ldmfd sp!, {r4-r12, pc} > > >> ENDPROC(omap_smc2) > > >> > > >> +/** > > >> + * u32 omap_smc3(u32 service_id, u32 process_id, u32 flag, u32 pargs) > > >> + * Low level common routine for secure HAL and PPA APIs via smc #1 > > >> + * r0 - @service_id: Secure Service ID > > >> + * r1 - @process_id: Process ID > > >> + * r2 - @flag: Flag to indicate the criticality of operation > > >> + * r3 - @pargs: Physical address of parameter list > > >> + */ > > >> +ENTRY(omap_smc3) > > >> + stmfd sp!, {r4-r12, lr} > > > > > >You don't need to save/restore r12. The ABI allows it to be clobbered > > >across function calls. > > > > > >> + mov r12, r0 @ Copy the secure service ID > > >> + mov r6, #0xff @ Indicate new Task call > > >> + dsb > > >> + dmb > > > > > >dsb synchronises a superset of what dmb synchronises, so the dmb here is > > >not useful. > > > > > >In any case, any code calling this must flush the region addressed by > > >r3 beforehand anyway, which will include a dsb as part of its semantics > > >-- this is how you call it from rx51_secure_dispatcher(). > > > > > >So I think the dsb may not be needed here (?) > > > > > >Cheers > > >---Dave > > > > > > > > > > Could be, but I wonder why almost all the kernel code(I am aware of) that uses SMC and is written by TI, is storing r12 and is using both DSB and DMB. See arch/arm/mach-omap2/sleep34xx.S or arch/arm/mach-omap2/omap-smc.S for examples. I'd rather play it safe and leave it that way, unless someone confirms the other code using SMC has extra DSB/DMB instructions too. I wouldn't risk passing invalid/stale data to the Secure Monitor to just save 8 bytes and barriers in a performance non-critical code which will be called only a couple of times during the boot-up process. r12 save/restore is a legacy from omap_smc2 in omap-smc.S, so I guess it can go away without much of a trouble. > > > Dave pointed out about the dsb and r12 to me in another thread. R12 can be easily removed > but the DSB's were needed on OMAP for power sequencing. Without those, we have seen > many issues. So you can leave the dsb's to be consistent with rest of the code. Consistency is a perfectly good reason, especially in code like this where a certain code sequence has been proven, but it's preferable to include brief comments to explain nonetheless. Difficulty in explaining precisely why something is needed should be a warning flag that a comment is needed. Cheers ---Dave ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 2013-07-12 10:24 ` Dave Martin @ 2013-08-04 8:45 ` Pali Rohár 2013-08-05 13:29 ` Dave Martin 0 siblings, 1 reply; 5+ messages in thread From: Pali Rohár @ 2013-08-04 8:45 UTC (permalink / raw) To: linux-arm-kernel Here is new version (v3) of omap secure part patch: Other secure functions omap_smc1() and omap_smc2() calling instruction smc #0 but Nokia RX-51 board needs to call smc #1 for PPA access. Signed-off-by: Ivaylo Dimitrov <freemangordon@abv.bg> Signed-off-by: Pali Roh?r <pali.rohar@gmail.com> --- diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h index 0e72917..c4586f4 100644 --- a/arch/arm/mach-omap2/omap-secure.h +++ b/arch/arm/mach-omap2/omap-secure.h @@ -51,6 +51,7 @@ extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2, u32 arg3, u32 arg4); extern u32 omap_smc2(u32 id, u32 falg, u32 pargs); +extern u32 omap_smc3(u32 id, u32 process, u32 flag, u32 pargs); extern phys_addr_t omap_secure_ram_mempool_base(void); extern int omap_secure_ram_reserve_memblock(void); diff --git a/arch/arm/mach-omap2/omap-smc.S b/arch/arm/mach-omap2/omap-smc.S index f6441c1..7bbc043 100644 --- a/arch/arm/mach-omap2/omap-smc.S +++ b/arch/arm/mach-omap2/omap-smc.S @@ -1,9 +1,11 @@ /* - * OMAP44xx secure APIs file. + * OMAP34xx and OMAP44xx secure APIs file. * * Copyright (C) 2010 Texas Instruments, Inc. * Written by Santosh Shilimkar <santosh.shilimkar@ti.com> * + * Copyright (C) 2012 Ivaylo Dimitrov <freemangordon@abv.bg> + * Copyright (C) 2013 Pali Roh?r <pali.rohar@gmail.com> * * This program is free software,you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -54,6 +56,23 @@ ENTRY(omap_smc2) ldmfd sp!, {r4-r12, pc} ENDPROC(omap_smc2) +/** + * u32 omap_smc3(u32 service_id, u32 process_id, u32 flag, u32 pargs) + * Low level common routine for secure HAL and PPA APIs via smc #1 + * r0 - @service_id: Secure Service ID + * r1 - @process_id: Process ID + * r2 - @flag: Flag to indicate the criticality of operation + * r3 - @pargs: Physical address of parameter list + */ +ENTRY(omap_smc3) + stmfd sp!, {r4-r11, lr} + mov r12, r0 @ Copy the secure service ID + mov r6, #0xff @ Indicate new Task call + dsb @ Memory Barrier + smc #1 @ Call PPA service + ldmfd sp!, {r4-r11, pc} +ENDPROC(omap_smc3) + ENTRY(omap_modify_auxcoreboot0) stmfd sp!, {r1-r12, lr} ldr r12, =0x104 -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130804/c2ba9517/attachment.sig> ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 2013-08-04 8:45 ` [PATCH v3 " Pali Rohár @ 2013-08-05 13:29 ` Dave Martin 0 siblings, 0 replies; 5+ messages in thread From: Dave Martin @ 2013-08-05 13:29 UTC (permalink / raw) To: linux-arm-kernel On Sun, Aug 04, 2013 at 10:45:00AM +0200, Pali Roh?r wrote: > Here is new version (v3) of omap secure part patch: > > Other secure functions omap_smc1() and omap_smc2() calling instruction smc #0 > but Nokia RX-51 board needs to call smc #1 for PPA access. > > Signed-off-by: Ivaylo Dimitrov <freemangordon@abv.bg> > Signed-off-by: Pali Roh?r <pali.rohar@gmail.com> > --- > diff --git a/arch/arm/mach-omap2/omap-secure.h b/arch/arm/mach-omap2/omap-secure.h > index 0e72917..c4586f4 100644 > --- a/arch/arm/mach-omap2/omap-secure.h > +++ b/arch/arm/mach-omap2/omap-secure.h > @@ -51,6 +51,7 @@ > extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, > u32 arg1, u32 arg2, u32 arg3, u32 arg4); > extern u32 omap_smc2(u32 id, u32 falg, u32 pargs); > +extern u32 omap_smc3(u32 id, u32 process, u32 flag, u32 pargs); > extern phys_addr_t omap_secure_ram_mempool_base(void); > extern int omap_secure_ram_reserve_memblock(void); > > diff --git a/arch/arm/mach-omap2/omap-smc.S b/arch/arm/mach-omap2/omap-smc.S > index f6441c1..7bbc043 100644 > --- a/arch/arm/mach-omap2/omap-smc.S > +++ b/arch/arm/mach-omap2/omap-smc.S > @@ -1,9 +1,11 @@ > /* > - * OMAP44xx secure APIs file. > + * OMAP34xx and OMAP44xx secure APIs file. > * > * Copyright (C) 2010 Texas Instruments, Inc. > * Written by Santosh Shilimkar <santosh.shilimkar@ti.com> > * > + * Copyright (C) 2012 Ivaylo Dimitrov <freemangordon@abv.bg> > + * Copyright (C) 2013 Pali Roh?r <pali.rohar@gmail.com> > * > * This program is free software,you can redistribute it and/or modify > * it under the terms of the GNU General Public License version 2 as > @@ -54,6 +56,23 @@ ENTRY(omap_smc2) > ldmfd sp!, {r4-r12, pc} > ENDPROC(omap_smc2) > > +/** > + * u32 omap_smc3(u32 service_id, u32 process_id, u32 flag, u32 pargs) > + * Low level common routine for secure HAL and PPA APIs via smc #1 > + * r0 - @service_id: Secure Service ID > + * r1 - @process_id: Process ID > + * r2 - @flag: Flag to indicate the criticality of operation > + * r3 - @pargs: Physical address of parameter list > + */ > +ENTRY(omap_smc3) > + stmfd sp!, {r4-r11, lr} > + mov r12, r0 @ Copy the secure service ID > + mov r6, #0xff @ Indicate new Task call > + dsb @ Memory Barrier Can you explain _why_ the barrier is there? The reader doesn't need to be told that a barrier instruction is a barrier instruction. Cheers ---Dave ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <2121638991.49538.1376246200421.JavaMail.apache@mail81.abv.bg>]
* [PATCH v3 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 [not found] <2121638991.49538.1376246200421.JavaMail.apache@mail81.abv.bg> @ 2013-09-04 8:10 ` Pali Rohár 0 siblings, 0 replies; 5+ messages in thread From: Pali Rohár @ 2013-09-04 8:10 UTC (permalink / raw) To: linux-arm-kernel On Sunday 11 August 2013 20:36:40 ?????? ???????? wrote: > >-------- ?????????? ????? -------- > > > >??: Dave Martin > >???????: Re: [PATCH v3 1/2] ARM: OMAP: Add secure function > >omap_smc3() which > > calling instruction smc #1 > > >??: Pali Roh?r > >????????? ??: ??????????, 2013, ?????? 5 16:29:44 EEST > > > >On Sun, Aug 04, 2013 at 10:45:00AM +0200, Pali Roh?r wrote: > >> Here is new version (v3) of omap secure part patch: > >> > >> Other secure functions omap_smc1() and omap_smc2() calling > >> instruction smc #0 but Nokia RX-51 board needs to call > >> smc #1 for PPA access. > >> > >> Signed-off-by: Ivaylo Dimitrov > >> Signed-off-by: Pali Roh?r > >> --- > >> diff --git a/arch/arm/mach-omap2/omap-secure.h > >> b/arch/arm/mach-omap2/omap-secure.h index > >> 0e72917..c4586f4 100644 > >> --- a/arch/arm/mach-omap2/omap-secure.h > >> +++ b/arch/arm/mach-omap2/omap-secure.h > >> @@ -51,6 +51,7 @@ > >> > >> extern u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 > >> nargs, > >> > >> u32 arg1, u32 arg2, u32 arg3, u32 arg4); > >> > >> extern u32 omap_smc2(u32 id, u32 falg, u32 pargs); > >> > >> +extern u32 omap_smc3(u32 id, u32 process, u32 flag, u32 > >> pargs); > >> > >> extern phys_addr_t omap_secure_ram_mempool_base(void); > >> extern int omap_secure_ram_reserve_memblock(void); > >> > >> diff --git a/arch/arm/mach-omap2/omap-smc.S > >> b/arch/arm/mach-omap2/omap-smc.S index f6441c1..7bbc043 > >> 100644 > >> --- a/arch/arm/mach-omap2/omap-smc.S > >> +++ b/arch/arm/mach-omap2/omap-smc.S > >> @@ -1,9 +1,11 @@ > >> > >> /* > >> > >> - * OMAP44xx secure APIs file. > >> + * OMAP34xx and OMAP44xx secure APIs file. > >> > >> * > >> * Copyright (C) 2010 Texas Instruments, Inc. > >> * Written by Santosh Shilimkar > >> * > >> > >> + * Copyright (C) 2012 Ivaylo Dimitrov > >> + * Copyright (C) 2013 Pali Roh?r > >> > >> * > >> * This program is free software,you can redistribute it > >> and/or modify * it under the terms of the GNU General > >> Public License version 2 as > >> > >> @@ -54,6 +56,23 @@ ENTRY(omap_smc2) > >> > >> ldmfd sp!, {r4-r12, pc} > >> > >> ENDPROC(omap_smc2) > >> > >> +/** > >> + * u32 omap_smc3(u32 service_id, u32 process_id, u32 > >> flag, u32 pargs) + * Low level common routine for secure > >> HAL and PPA APIs via smc #1 + * r0 - @service_id: Secure > >> Service ID > >> + * r1 - @process_id: Process ID > >> + * r2 - @flag: Flag to indicate the criticality of > >> operation + * r3 - @pargs: Physical address of parameter > >> list + */ > >> +ENTRY(omap_smc3) > >> + stmfd sp!, {r4-r11, lr} > >> + mov r12, r0 @ Copy the secure service ID > >> + mov r6, #0xff @ Indicate new Task call > >> + dsb @ Memory Barrier > > > >Can you explain _why_ the barrier is there? The reader > >doesn't need to be told that a barrier instruction is a > >barrier instruction. > > > >Cheers > >---Dave > > Hi Dave, > > Would quoting Santosh's explanation "DSBs were needed on OMAP > for power sequencing." do the job? Something like "@ Needed > on OMAP for power sequencing" instead of "@ Memory Barrier". > > I want to be sure I correctly understand your requirement. > > Regards, > Ivo Hello, I'd like to know what happened with this patch? What is needed for including it into mainline? Note that without with this patch series Thumb-2 user space binaries crashing. -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130904/79378b50/attachment-0001.sig> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-04 8:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <531356997.66774.1373571839852.JavaMail.apache@mail81.abv.bg>
2013-07-11 19:54 ` [PATCH v2 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 Santosh Shilimkar
2013-07-12 10:24 ` Dave Martin
2013-08-04 8:45 ` [PATCH v3 " Pali Rohár
2013-08-05 13:29 ` Dave Martin
[not found] <2121638991.49538.1376246200421.JavaMail.apache@mail81.abv.bg>
2013-09-04 8:10 ` Pali Rohár
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).