From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD
Date: Wed, 7 Aug 2013 04:09:45 -0700 [thread overview]
Message-ID: <20130807110945.GL7656@atomide.com> (raw)
In-Reply-To: <C635EF21-CD18-4633-AA39-16209F8EE231@gmail.com>
* Chen Baozi <baozich@gmail.com> [130805 08:33]:
> ping?
>
> On Aug 1, 2013, at 7:27 PM, Chen Baozi <baozich@gmail.com> wrote:
>
> > The denominator should be load from INCREMENTOR_DENUMERATOR_RELOAD_OFFSET
> > rather than INCREMENTER_NUMERATOR_OFFSET.
Maybe describe what exactly happens without this fix?
Also we should get few acks for this for the -rc series.
Regards,
Tony
> > Signed-off-by: Chen Baozi <baozich@gmail.com>
> > ---
> > arch/arm/mach-omap2/timer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> > index b37e1fc..9265e03 100644
> > --- a/arch/arm/mach-omap2/timer.c
> > +++ b/arch/arm/mach-omap2/timer.c
> > @@ -537,7 +537,7 @@ static void __init realtime_counter_init(void)
> > reg |= num;
> > __raw_writel(reg, base + INCREMENTER_NUMERATOR_OFFSET);
> >
> > - reg = __raw_readl(base + INCREMENTER_NUMERATOR_OFFSET) &
> > + reg = __raw_readl(base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET) &
> > NUMERATOR_DENUMERATOR_MASK;
> > reg |= den;
> > __raw_writel(reg, base + INCREMENTER_DENUMERATOR_RELOAD_OFFSET);
> > --
> > 1.8.1.4
> >
>
next prev parent reply other threads:[~2013-08-07 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 11:27 [PATCH] ARM: fix wrong address when loading PRM_FRAC_INCREMENTOR_DENUMERATOR_RELOAD Chen Baozi
2013-08-05 15:26 ` Chen Baozi
2013-08-07 11:09 ` Tony Lindgren [this message]
2013-08-07 13:35 ` Chen Baozi
-- strict thread matches above, loose matches on Subject: below --
2013-08-07 14:05 Chen Baozi
2013-08-21 8:03 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807110945.GL7656@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).