* [PATCH] ARM: fix typo in is_gate_vma() macro
@ 2013-08-06 21:34 Mathias Krause
2013-08-07 12:55 ` Russell King - ARM Linux
0 siblings, 1 reply; 2+ messages in thread
From: Mathias Krause @ 2013-08-06 21:34 UTC (permalink / raw)
To: linux-arm-kernel
Commit a5463cd3 "ARM: make vectors page inaccessible from userspace"
introduced a typo making arch_vma_name() always return "[vectors]".
Fix up that regression (of the hush-hush security fix).
Signed-off-by: Mathias Krause <minipli@googlemail.com>
---
arch/arm/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 16ed3f7..34fe52d 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -462,7 +462,7 @@ int in_gate_area_no_mm(unsigned long addr)
{
return in_gate_area(NULL, addr);
}
-#define is_gate_vma(vma) ((vma) = &gate_vma)
+#define is_gate_vma(vma) ((vma) == &gate_vma)
#else
#define is_gate_vma(vma) 0
#endif
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: fix typo in is_gate_vma() macro
2013-08-06 21:34 [PATCH] ARM: fix typo in is_gate_vma() macro Mathias Krause
@ 2013-08-07 12:55 ` Russell King - ARM Linux
0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2013-08-07 12:55 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 06, 2013 at 11:34:35PM +0200, Mathias Krause wrote:
> Commit a5463cd3 "ARM: make vectors page inaccessible from userspace"
> introduced a typo making arch_vma_name() always return "[vectors]".
> Fix up that regression (of the hush-hush security fix).
And if you search the list archives, you will see that I've already
replied to patches exactly like this many times so far. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-07 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 21:34 [PATCH] ARM: fix typo in is_gate_vma() macro Mathias Krause
2013-08-07 12:55 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).