From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] clk: exynos4: Fix incorrect placement of __initdata
Date: Wed, 07 Aug 2013 10:27:51 -0700 [thread overview]
Message-ID: <20130807172751.5348.32832@quantum> (raw)
In-Reply-To: <1375850921-23122-1-git-send-email-sachin.kamat@linaro.org>
Quoting Sachin Kamat (2013-08-06 21:48:37)
> __initdata should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied on top of the "[PATCH 1/3] clk: exynos4: Make exynos4_plls
static" series in clk-next.
Thanks for following up on this.
Regards,
Mike
> ---
> drivers/clk/samsung/clk-exynos4.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c
> index fec319d..742b4c5 100644
> --- a/drivers/clk/samsung/clk-exynos4.c
> +++ b/drivers/clk/samsung/clk-exynos4.c
> @@ -194,7 +194,7 @@ enum exynos4_clks {
> * list of controller registers to be saved and restored during a
> * suspend/resume cycle.
> */
> -static __initdata unsigned long exynos4210_clk_save[] = {
> +static unsigned long exynos4210_clk_save[] __initdata = {
> E4210_SRC_IMAGE,
> E4210_SRC_LCD1,
> E4210_SRC_MASK_LCD1,
> @@ -205,7 +205,7 @@ static __initdata unsigned long exynos4210_clk_save[] = {
> E4210_MPLL_CON0,
> };
>
> -static __initdata unsigned long exynos4x12_clk_save[] = {
> +static unsigned long exynos4x12_clk_save[] __initdata = {
> E4X12_GATE_IP_IMAGE,
> E4X12_GATE_IP_PERIR,
> E4X12_SRC_CAM1,
> @@ -214,7 +214,7 @@ static __initdata unsigned long exynos4x12_clk_save[] = {
> E4X12_MPLL_CON0,
> };
>
> -static __initdata unsigned long exynos4_clk_regs[] = {
> +static unsigned long exynos4_clk_regs[] __initdata = {
> SRC_LEFTBUS,
> DIV_LEFTBUS,
> GATE_IP_LEFTBUS,
> @@ -978,13 +978,13 @@ static void __init exynos4_clk_register_finpll(unsigned long xom)
>
> }
>
> -static __initdata struct of_device_id ext_clk_match[] = {
> +static struct of_device_id ext_clk_match[] __initdata = {
> { .compatible = "samsung,clock-xxti", .data = (void *)0, },
> { .compatible = "samsung,clock-xusbxti", .data = (void *)1, },
> {},
> };
>
> -static struct __initdata samsung_pll_clock exynos4_plls[nr_plls] = {
> +static struct samsung_pll_clock exynos4_plls[nr_plls] __initdata = {
> [apll] = PLL_A(pll_35xx, fout_apll, "fout_apll", "fin_pll", APLL_LOCK,
> APLL_CON0, "fout_apll", NULL),
> [mpll] = PLL_A(pll_35xx, fout_mpll, "fout_mpll", "fin_pll",
> --
> 1.7.9.5
prev parent reply other threads:[~2013-08-07 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 4:48 [PATCH 1/4] clk: exynos4: Fix incorrect placement of __initdata Sachin Kamat
2013-08-07 4:48 ` [PATCH 2/4] clk: exynos5250: " Sachin Kamat
2013-08-07 4:48 ` [PATCH 3/4] clk: exynos5420: " Sachin Kamat
2013-08-07 4:48 ` [PATCH 4/4] clk: exynos5440: " Sachin Kamat
2013-08-07 17:27 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807172751.5348.32832@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).