linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pinctrl: shut up a couple of pinctrl warnings
Date: Wed, 7 Aug 2013 21:16:44 +0200	[thread overview]
Message-ID: <20130807191644.GK6104@pengutronix.de> (raw)
In-Reply-To: <20130728121300.GF24642@n2100.arm.linux.org.uk>

Hello,

On Sun, Jul 28, 2013 at 01:13:00PM +0100, Russell King - ARM Linux wrote:
> diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
> index e875f21..d16ef87 100644
> --- a/drivers/pinctrl/pinconf.c
> +++ b/drivers/pinctrl/pinconf.c
> [...]
> @@ -450,14 +449,8 @@ static int pinconf_dbg_config_print(struct seq_file *s, void *d)
>  		for (j = 0; j < map->data.configs.num_configs; j++) {
>  			if (!strcmp(map->data.configs.group_or_pin,
>  					dbg->pin_name)) {
> -				/*
> -				 * We found the right pin / state, read the
> -				 * config and he pctldev for later use
he?

> -				 */
> -				configs = &map->data.configs;
> -				pctldev = get_pinctrl_dev_from_devname
> -					(map->ctrl_dev_name);
> -				found = true;
> +				/* We found the right pin / state */
> +				found = map;
>  				break;
>  			}
>  		}

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  parent reply	other threads:[~2013-08-07 19:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-27 10:38 [PATCH] pinctrl: shut up a couple of pinctrl warnings Russell King - ARM Linux
2013-07-28 12:13 ` [PATCH v2] " Russell King - ARM Linux
2013-08-07 18:19   ` Linus Walleij
2013-08-07 19:16   ` Uwe Kleine-König [this message]
2013-08-07 19:54     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130807191644.GK6104@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).